-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail on iOS when WKWebView plugin is present #52
Comments
I reproduced this issue.
However this HttpRequest fails in WKWebView. I found the following error
Here are my screenshots |
If I edit
and edit
(url is the custom WkWebView plugin location in your mac)
However |
I created a plugin to support cordova-paramedic test in iOS: https://github.com/knight9999/cordova-plugin-wkwebview-engine-allowfileaccess Could you please try to use this plugin as
in |
Yep, works great, Travis tests are now passing. |
So nice. If this works, it is better to create a new plugin in |
(Great work @knight9999!) Seems like a good idea to create an additional plugin in |
@knight9999 I think your plugin should actually not live in That being said, the way @dpa99c currently included the plugin doesn't really match how e.g. cordova-paramedic/lib/paramedic.js Lines 173 to 175 in 9146804
There are multiple of those: cordova-paramedic/lib/paramedic.js Lines 167 to 178 in 9146804
Those are the ones that are included here in this repo. I think @dpa99c should probably include the plugin in "his" own test folder to make it work best - or it stays in a separate repo. |
Closing out this issue as the WKWebView plugin was deprecated. |
Currently, if you add
cordova-plugin-wkwebview-engine
as a plugin dependency to thetests/plugin.xml
of a plugin then run the tests against the iOS platform usingcordova-paramedic
, they will fail because the local server times out waiting for a connection, despite the tests actually passing in the Simulator.As highlighted in my comment, this is causing the Travis CI tests to fail for my PR to add WKWebView support to
cordova-plugin-inappbrowser
.With UIWebView being deprecated in iOS 12 and the intention to add implicit WKWebView support to
cordova-ios@5
, there is a need to resolve this issue other than to unblock my PR.Travis CI console output
The text was updated successfully, but these errors were encountered: