Moving message in PR template to a comment #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikhilkh please review |
|
I wonder if we should shorten the commit message bullet so that it doesn't wrap lines like that? Maybe we can link to http://cordova.apache.org/contribute/contribute_guidelines.html instead of giving an example (though that page doesn't have anchors for the headings) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
None!
What does this PR do?
Change the template that I am currently filling out so that the checklist message is in a comment
What testing has been done on this change?
Absolutely none.
Checklist
Please make sure these boxes are checked before submitting the PR. This checklist is intended as a quick reference, for complete details please see our Contributor Guidelines. Thanks!