CB-10636 Add JSHint for plugins #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one issue remaining:
|
|
@vladimir-kotikov, could you please take a look? |
.jshintrc
Outdated
| @@ -0,0 +1,16 @@ | |||
| { | |||
| "node": true | |||
There was a problem hiding this comment.
Shouldn't we use browser: true instead and add define, module and require to globals?
|
Addressed, thanks for review, @vladimir-kotikov. |
|
I think this is because of https://developer.mozilla.org/docs/Web/API/Window/name |
.travis.yml
Outdated
| language: node_js | ||
| sudo: false | ||
| node_js: | ||
| - "0.10" |
There was a problem hiding this comment.
There is no point in running jshint for all 3 versions of node.js. We should just have 1 version here.
Added Travis badge Added node_modules to gitignore Disabled quotmark as it is deprecated Fixed jshint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Travis badge
Added node_modules to gitignore
Disabled quotmark as it is deprecated
Fixed jshint issues
Jira issue