CB-10977 android: Removing global state used for permission requests #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| callback.sendPluginResult(new PluginResult(PluginResult.Status.ERROR, SECURITY_ERR)); | ||
| if(r == PackageManager.PERMISSION_DENIED) | ||
| { | ||
| req.getCallbackContext().sendPluginResult(new PluginResult(PluginResult.Status.ERROR, SECURITY_ERR)); |
There was a problem hiding this comment.
Should there be a return after this line?
There was a problem hiding this comment.
Ha, yep! Good catch! It doesn't look like there was a return there before either so I wonder how that worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The associated JIRA is CB-10977. Check out the description on the issue for an explanation of the problem. I also added some JS that reproduces it in the comments. This fix is contingent on apache/cordova-android#285 to completely fix the problem (I plan to merge that PR soon).
This will also change the behavior when used with older versions of cordova-android (i.e. without apache/cordova-android#285) and should prevent some of the weirder bugs. The behavior will still be incorrect, but less so.