-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-14091: fix tests code for stream url and remove browser #166
Conversation
@shazron Strange error since I’ve only fixed the iOS portion. Maybe it’s an TravisCI error so could you re-run the test if that’s possible? |
@knight9999 I'll close and re-open this PR to re-trigger Travis |
Looks like |
Actually, looks like an |
See npm/npm#9418 (comment) |
upgraded node.js to use 6.14.2 Node 4 is deprecated.
It appears that the test version of node_js was still using 4.2 which have already been deprecated in other Cordova repos for example cordova-cli. I have upgraded the Travis CI yaml file to reflect this change and now use version 6.14.2. All tests except for the Android 4.4 are now passing. |
I have removed tests of streaming for Android 4.4. Remark that I have used one test mp3 file |
I'm not sure we have the copyright, any files we put on Apache need to have the right license (Apache 2.0 or one of the approved licenses). |
I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org. (https://web.archive.org/web/20170205201205if_/http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3) If you can copy the original mp3 file ch_classic_128.mp3 to the cordova official site (For example, https://cordova.apache.org/downloads/), please copy it to use in testing. |
Sorry to be a stickler on this -- just because something is in the Wayback Machine, does not mean that it lacks copyright. Until we can assert what license the file is in (like any code contribution), we can't add it to Apache. For example, BlueZed.mp3 was an original creation by @purplecabbage, a Cordova Committer and PMC member and assigned to Apache. In any case, I'm sure we can find a public domain/Apache-2.0 licensed music sample somewhere. For example, any of the clips here are public domain: https://musopen.org/ |
Why you not like song? Is it rock too hard? |
Thanks shazron and purplecabbage, |
my song is really just 8 bars repeating for 60 seconds ... the word 'song' may be a bit of stretch ... |
* fix tests code for fix stream url and remove browser * Update .travis.yml - upgraded node.js to use 6.14.2 (Node 4 is deprecated) * remove streaming test for Android 4.4 (KitKat does not support modern SSL)
Platforms affected
Tests code only
Browser (test)
iOS (test)
What does this PR do?
Removing Browser's play audio tests. (which fails)
Change test streaming mp3 file's url in iOS tests.
What testing has been done on this change?
Checklist