-
Notifications
You must be signed in to change notification settings - Fork 222
Update docs for PUT attachments #120
Conversation
Thanks for taking a look. In this case I wanted to check because wasn't sure. I still see those headers as valid thought. Here is how I tested: (Used latest master, then python-couchdb in ipython prompt and httpie command line tool)
Created a db
Listing the attachments we see that text/* one we get the Content-Encoding and the Content-Length as compressed values. But interestingly (but not surprising) we can't do Accept-Range requests for it.
|
You're right. I modified the wrong headers. I meant to update the PUT description not HEAD. Updated. |
I'd also love to update this for the 1.6 docs. Do we have a way to update historical documentation? |
These headers were completely misdocumented, even for Couch 1.6. But they've all been removed entirely for Couch 2.0.0, according to my testing.
Ah I see. To be fair, I noticed, I messed up as well as I didn't check HEAD, only GET. Yeah I imagine Accept-Ranges might not apply to PUT but will need to verify it. As for 1.6 try to checkout 1.6.x branch then look in share/doc folder. I imagine making a PR then to that 1.6.x branch. But I am not too familiar with that process there TBH. @wohali, you did some documentation work, do you have any guidance on updating 1.6.x documentation and how it differs from 2.0 |
From RFC 7233, 3.1:
By extension, it seems logical that advertising |
Good find! |
+1 Thank you! |
These headers were completely misdocumented, even for Couch 1.6. But
they've all been removed entirely for Couch 2.0.0, according to my testing.