Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

Conversation

jaydoane
Copy link
Contributor

Overview

This fixes the broken reference to the PUT db API

Testing recommendations

make html and open build/html/config/cluster.html locally to confirm link works

Not sure if this is really passing though?

$ make check
python3 ext/linter.py src/
$ echo $?
0

GitHub issue number

FIxes #383

Related Pull Requests

Checklist

  • Documentation is written and is accurate;
  • make check passes with no errors
  • Update rebar.config.script with the commit hash once this PR is rebased and merged

@jaydoane jaydoane requested a review from wohali January 24, 2019 20:29
@jaydoane
Copy link
Contributor Author

@wohali I tried to create a link directly to the PUT anchor but couldn't figure it out. Is there are way to do so?

@wohali
Copy link
Member

wohali commented Jan 24, 2019

@jaydoane We use an old version of https://sphinxcontrib-httpdomain.readthedocs.io/en/stable/ for the http stuff. (At some point we should unbundle our version under ext/ and just use pip to install it.)

It's implemented as a Sphinx domain, so http://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html should help as well.

:http:put:`PUT /{db} </{db}>`

should work.

@jaydoane jaydoane force-pushed the config-cluster-ref-fix branch from 525bbb9 to 81ae3d8 Compare January 25, 2019 00:47
@jaydoane
Copy link
Contributor Author

@wohali yes, that was the magic -- thanks!

@wohali wohali merged commit aea530b into master Feb 1, 2019
@wohali wohali deleted the config-cluster-ref-fix branch February 1, 2019 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken cross-reference in [cluster] configuration
2 participants