Skip to content
This repository was archived by the owner on Oct 17, 2022. It is now read-only.

Conversation

iilyak
Copy link
Contributor

@iilyak iilyak commented May 28, 2019

Overview

RFC for using ExUnit for unit tests

Testing recommendations

N/A

GitHub issue number

N/A

Related Pull Requests

Checklist

  • Documentation is written and is accurate;
  • make check passes with no errors
  • Update rebar.config.script with the commit hash once this PR is rebased and merged

@iilyak iilyak mentioned this pull request May 28, 2019
3 tasks

# Introduction

With the upgrade of supported Erlang version and introduction of Elixir into our
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just this paragraph should be the introduction. Then the section below should be below the abstract as an actual reason why we want to move to exunit.


## Abstract

Write necessary plumbing to be able to use ExUnit in unit tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the abstracts really confusing but I think this should be more a full summary of the whole RFC. Which is something like, we want to replace eunit because it has a bunch of issues, we will use exunit instead, it solves a lot of these problems. The advantage is we would then use a modern testing framework which is consistent for unit and integration tests.

@iilyak
Copy link
Contributor Author

iilyak commented May 30, 2019

@garrensmith I moved sections as you've advised.

Copy link
Member

@garrensmith garrensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Looking forward to using it in our tests.

@iilyak iilyak merged commit ffcf1fb into apache:master Jun 14, 2019
@iilyak iilyak deleted the rfc/009-exunit branch June 14, 2019 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants