-
Notifications
You must be signed in to change notification settings - Fork 222
Fix os_process_limit documentation #88
Fix os_process_limit documentation #88
Conversation
Update documentation with correct description of os_process_limit parameter function, correct default value, and hints for typical production values. COUCHDB-3238
|
||
[query_server_config] | ||
os_process_limit = 10 | ||
os_process_limit = 25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default is 100.
Query Servers, and manifest in `os_process_timeout` errors, | ||
while setting it too high can potentially use too many system | ||
resources. Production settings are typically 10-100 times the | ||
default value. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a section for os_process_soft_limit too? (also defaults to 100)
While the internal default is indeed 100, it's set to 25 in rel/overlay/etc/default.ini -- so I guess it depends on what you mean by "default". I'm happy to change it to 100, though. Also, added a section on os_process_soft_limit, which could probably use better word-smithing. |
heh, so it is, how silly. a hard limit of 25 and a soft limit of 100 (since it's not specified in default.ini), that's a nonsense setup. |
@rnewson thanks for the review. If you're ok with this, can you +1 and merge for me? Also, shall I open a PR to just remove the explicit hard limit of 25 in default.ini? |
I'll merge this. please open a PR to fix the 25 -> 100 thing in default.ini. |
I took care of it. thanks for the doc patch. |
Update documentation with correct description of os_process_limit
parameter function, correct default value, and hints for typical
production values.
COUCHDB-3238