Skip to content

Conversation

benkeen
Copy link
Member

@benkeen benkeen commented Feb 17, 2015

Contains a small fix to ensure a unicode char in the db typeahead
component is URL encoded. If the server needed to recognize the
endkey parameter it would cause problems on IE.

This doesn't currently cause any problems on Fauxton, note, so
there's nothing to test there.

Closes COUCHDB-2587

@garrensmith
Copy link
Member

@benkeen can you add a test. All fixes must include a test. You don't have to do a nightwatch test. A simple mocha test to make sure the url is encoded is good enough.

@benkeen benkeen force-pushed the 2587-typeahead-encoding-fix branch from 4abfd6f to 97c1548 Compare February 24, 2015 17:27
@benkeen
Copy link
Member Author

benkeen commented Feb 24, 2015

Mocha test added. I had to refactor the component a bit to expose a convenient getURL() method through which I could examine the URL.

@robertkowalski
Copy link
Member

+1

@benkeen benkeen force-pushed the 2587-typeahead-encoding-fix branch from 97c1548 to 7c07613 Compare February 25, 2015 15:44
Contains a small fix to ensure a unicode char in the db typeahead
component is URL encoded. If the server needed to recognize the
endkey parameter it would cause problems on IE.

Closes COUCHDB-2587
@benkeen
Copy link
Member Author

benkeen commented Feb 25, 2015

Merged as 88148d6 [squashed, hence the travis re-run]

@benkeen benkeen closed this Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants