Consume JSON body even when its content is ignored #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Fixes COUCHDB-2583
|
(note that the Travis CI build passed, it looks like there has been a change in configuration as both builds — in progress and passed — point to the same URL) |
|
@samueltardieu Could you please rebase your PR against 1.x.x branch - if there will happens 1.x release it will be 1.7, not 1.6.2. Also to let your patch be included in 2.0 submit it to https://github.com/apache/couchdb-couch/ . Worth to check if something is needed to add for cluster httpd interface (https://github.com/apache/couchdb-chttpd/), but it seems not. |
|
Ok, will resubmit. |
janl
pushed a commit
that referenced
this pull request
Jan 5, 2020
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"_ensure_full_commit" and "_compact" require that the content-type be set to "application/json". However, when some content is provided (such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content is read from the incoming HTTP request.
Fixes COUCHDB-2583