Add more features to QuickJS scanner #5338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand scanning for update handlers and text indexes. * Even though Nouveau is experimental, users seem to be excited to try it out, so ensure we also check compatibility for it. Once we check Nouveau, checking Clouseau is not a big deal then, so let's do that as well. * Deliberatly use `RegExp.$1` incompatibility to exercise warning logs. * We still have `lists` and `shows` left. `lists` are quite a bit trickier to test as they involved a streaming sub-protocol. So maybe leave them for later.
nickva
force-pushed
the
add-more-quickjs-scanner-checks
branch
from
631ad54 to
d8d54db
Compare
jiahuili430
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand scanning for update handlers and text indexes.
Even though Nouveau is experimental, users seem to be excited to try it out, so ensure we also check compatibility for it. Once we check Nouveau, checking Clouseau is not a big deal then, so let's do that as well.
Deliberately use
RegExp.$1incompatibility to exercise warning logs.We still have
listsandshowsleft.listsare quite a bit trickier to test as they involved a streaming sub-protocol. So maybe leave them for later.