[CURATOR-430] deletingChildrenIfNeeded maybe cannot delete children completely when multi-client delete concurrently

[heziai]

use curatorFramework.delete().deletingChildrenIfNeeded().forPath(path), this sync api doesn't ignore the NoNodeException, causes the rest of children nodes will not be deleted perhaps.

zookeeper.getChildren(path, null) maybe throw NoNodeException, if the path doesn't exist.

[Randgalt]

Please include a test (something like the code you posted in the issue) for this. A good place to put the test is TestFrameworkEdges.java.

[lvfangmin]

The code looks good to me, except a minor comment.

[lvfangmin]

// someone else has deleted the node since we checked

[heziai]

haha... it's copied

[heziai]

Be sure this issue is bug? If yes, could you publish a fixed version based on v2.10.0?

[JunjianS]

i met the same problem, could u please provide a fixed version ?

[Randgalt]

If yes, could you publish a fixed version based on v2.10.0?

Curator 4.0 is now compatible with both ZK 3.4.x and 3.5.x so the 2.x versions of Curator will not be updated.

[Randgalt]

@hebelala hey - the test for this PR keeps failing and as I read it, I don't see how it ever worked. Can you look at this again? The code client2.delete().forPath("/parent/child" + (childCount / 2)); should actually fail most of the time as the thread has deleted all the children.