Set fail on warning for documentation generation #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eration" This reverts commit 1a8a7a4.
…n after wheel build
|
Demonstration of pipeline failure due to warnings: https://github.com/apache/datafusion-python/actions/runs/17344563181/job/49242828100?pr=1218 I'll now correct the warnings to get CI in the green |
… now that the setting is correct to turn warnings into errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
Currently we are generating warnings in our site documentation generation. This can lead to poor site building, as the documentation should always build cleanly. This sets warnings to generate an error so the CI pipeline will fail.
What changes are included in this PR?
buildstage to reuse a built wheel. This means one less build of the entire repo.Are there any user-facing changes?
No