feat: expose select_exprs method on DataFrame
#1271
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
reviewed
Oct 13, 2025
Comment on lines
408
to
415
| def select_exprs(self, *args: str) -> DataFrame: | ||
| """Project arbitrary list of expression strings into a new DataFrame. Method will parse string expressions into logical plan expressions. | ||
| The output DataFrame has one column for each element in exprs. | ||
| Returns: | ||
| DataFrame only containing the specified columns. | ||
| """ | ||
| return self.df.select_exprs(*args) |
There was a problem hiding this comment.
I think this will fail the ruff linter
There was a problem hiding this comment.
changed, will follow up later if it fails
timsaucer
reviewed
Oct 13, 2025
|
thanks @timsaucer |
|
I fixed the lint error. Thank you for the PR! I will merge as soon as I see CI finish. |
|
you were three minutes faster than me fixing it :) thanks @timsaucer maybe we could expose as a first step, not sure what do you think ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1270 .
Rationale for this change
Expose DataFrame.select_exprs method, which is supported in DataFusion, this method is similar to pyspark.select_expr
Method will parse string expressions into logical plan expressions, making easier to create select statements when expressions are involved
It would be ideal if we could support expressions on df.select(...) but that change looked as a bit complicated for me.
What changes are included in this PR?
Are there any user-facing changes?