Skip to content

Accept &str in Parse::parse_sql #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Accept &str in Parse::parse_sql #182

merged 1 commit into from
Jun 3, 2020

Conversation

Dandandan
Copy link
Contributor

It is more generic to accept a &str than a String in an API, and avoids having to convert a the string to a String when not needed, avoiding a copy.

@nickolay nickolay merged commit d32df52 into apache:master Jun 3, 2020
@nickolay
Copy link
Contributor

nickolay commented Jun 3, 2020

Good catch! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dandandan @nickolay