Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jun 16, 2025

I hit a small snag creating a 0.57.0 release due to a file not having the required apache license header.

I made another PR to add the headers

This PR adds a CI check to ensure newly added files have the header too

@alamb
Copy link
Contributor Author

alamb commented Jun 16, 2025

The new CI test fails with the same message I got when creating the release candidate, as expected (I expect it to fail until #1887 is merged)

https://github.com/apache/datafusion-sqlparser-rs/actions/runs/15678566227/job/44164458033?pr=1888

Run ./dev/release/run-rat.sh .
NOT APPROVED: rat.txt (./rat.txt): false
NOT APPROVED: src/display_utils.rs (./src/display_utils.rs): false
NOT APPROVED: tests/pretty_print.rs (./tests/pretty_print.rs): false
3 unapproved licences. Check rat report: rat.txt
Error: Process completed with exit code 1.

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb
Copy link
Contributor Author

alamb commented Jun 17, 2025

@alamb alamb merged commit be30697 into apache:main Jun 17, 2025
10 checks passed
@alamb alamb deleted the alamb/rat_ci branch June 17, 2025 14:47
solontsev pushed a commit to solontsev/datafusion-sqlparser-rs that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants