Enable merge queue in sqlparser-rs #2007
Conversation
|
I get that for this repo it isn't super critical since CI is fast, but:
|
In case something would go wrong during testing, we now have a way to force merge. So should be good to merge and test |
| on: | ||
| push: | ||
| branches-ignore: | ||
| - 'gh-readonly-queue/**' |
There was a problem hiding this comment.
What is this for? Can we perhaps add some comments explaining what this branch ignore is for?
| @@ -23,6 +23,7 @@ on: | |||
| branches: | |||
| - main | |||
| pull_request: | |||
| merge_group: | |||
There was a problem hiding this comment.
I reviewed https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#merge_group and this seems right to me
|
Small note for clarity: this pr itself won't enable MQ - this has to be done manually by the ASF Infra. But it'll make necessary changes on our side for that 🙂 |
|
I'm going to merge to test it. Will keep an eye on the repo - @iffyio if something is inconvenient with the new setup, feel free to ping me and I'll fix it |
|
All steps are now required - seems to be working :) 
Asked the infra time to enable the merge queue for this repo as we have everything set up on our side |
Which issue does this PR close?
Related to apache/datafusion#6880
Rationale for this change
Before we enable Merge Queue, we need to prepare our CI
What changes are included in this PR?
Merge Queue only waits for the required steps - us all checks are important hence I made them all required.
It'll become impossible to merge a PR if some of the checks are not passed, but I believe that's the flow we use now anyways.
I also added a MQ trigger as required in the MQ docs
Demo PR:
blaginin-org#1