Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot release DataFusion 36.0.0 to crates.io due to circular dependency #9277

Closed
andygrove opened this issue Feb 19, 2024 · 4 comments · Fixed by #9279
Closed

Cannot release DataFusion 36.0.0 to crates.io due to circular dependency #9277

andygrove opened this issue Feb 19, 2024 · 4 comments · Fixed by #9279
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

Describe the bug

It is not possible to publish datafusion-physical-expr to crates.io because it has a dependency on datafusion (datafusion-core), and datafusion-core depends on datafusion-physical-expr.

Caused by:
  failed to select a version for the requirement `datafusion = "^36.0.0"`
  candidate versions found which didn't match: 35.0.0, 34.0.0, 33.0.0, ...
  location searched: crates.io index
  required by package `datafusion-physical-expr v36.0.0 (/home/andy/git/apache/arrow-datafusion/target/package/datafusion-physical-expr-36.0.0)`

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@andygrove
Copy link
Member Author

The dependency was introduced in #9137

@Omega359
Copy link
Contributor

It should be just a dev dependency - I had to add it to get the rustdocs to work. I am unsure how that would affect crates.io deployment but removing it I think would require the removal (or moving ... to where I don't know) of the rustdoc for regexp_like.

@Omega359
Copy link
Contributor

Someone else with the same issue: https://users.rust-lang.org/t/circular-dev-dependency/69519/8

@andygrove
Copy link
Member Author

As a short-term fix, we can tag the rustdoc with ignore until we figure out a better solution. I have a PR up:

#9279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants