Add regexp_like, improve docs and examples for regexp_match`
#9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
FYI - the prettier error is not something I see on my machine |
This was referenced Feb 6, 2024
comphead
reviewed
Feb 6, 2024
comphead
reviewed
Feb 6, 2024
| regexp_like, regexp_match, regexp_replace, | ||
| }; | ||
|
|
||
| fn data(rng: &mut ThreadRng) -> StringArray { |
There was a problem hiding this comment.
that bench is really needed taking into account how much probs we had with regex performance
comphead
reviewed
Feb 6, 2024
| make_scalar_function_inner(func)(args) | ||
| } | ||
| other => { | ||
| internal_err!("Unsupported data type {other:?} for function regexp_like") |
There was a problem hiding this comment.
Suggested change
| internal_err!("Unsupported data type {other:?} for function regexp_like") | |
| exec_err!("Unsupported data type {other:?} for function regexp_like") |
There was a problem hiding this comment.
There is quite a few instances in the code that have this pattern (I was mirroring the existing regexp_... functions there) - I was going to create a followup PR that fixes them across the whole code base
There was a problem hiding this comment.
That would be most appreciated. Cleaning up internal errors that are possible to trigger via incrrect queries (rather than a bug) is very good improvement
comphead
reviewed
Feb 6, 2024
…d the test data to a csv file.
alamb
changed the title
regexp_like and regexp_match scalar functions
alamb
changed the title
regexp_like and regexp_match scalar functionsregexp_like, improve docs and examples for regexp_match`
alamb
approved these changes
Feb 8, 2024
| - [`flight_sql_server.rs`](examples/flight/flight_sql_server.rs): Run DataFusion as a standalone process and execute SQL queries from JDBC clients | ||
| - [`make_date.rs`](examples/make_date.rs): Examples of using the make_date function |
| @@ -0,0 +1,303 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Thank you -- this is much better
| return plan_err!("regexp_like() does not support the \"global\" option"); | ||
| } | ||
|
|
||
| let array = arrow_string::regexp::regexp_is_match_utf8(values, regex, Some(flags)) |
alamb
approved these changes
Feb 8, 2024
|
|
||
| // use dataframe and regexp_like function to test col 'values', against patterns in col 'patterns' with flags | ||
| let df = ctx | ||
| assert_batches_eq!( |
|
Thanks again @Omega359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9102
Rationale for this change
Add a new regexp_like function.
What changes are included in this PR?
Code, tests, documentation, perf test
Are these changes tested?
Yes,
Are there any user-facing changes?
A new regexp_like function is available for use.