Doc: Modify docs to fix old naming #10199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #9691 |
andygrove
reviewed
Apr 23, 2024
andygrove
reviewed
Apr 23, 2024
andygrove
reviewed
Apr 23, 2024
andygrove
reviewed
Apr 23, 2024
| @@ -37,7 +37,7 @@ We use the Slack and Discord platforms for informal discussions and coordination | |||
| meet other contributors and get guidance on where to contribute. It is important to note that any technical designs and | |||
| decisions are made fully in the open, on GitHub. | |||
|
|
|||
| Most of us use the `#arrow-datafusion` and `#arrow-rust` channels in the [ASF Slack workspace](https://s.apache.org/slack-invite) . | |||
| Most of us use the `#datafusion` and `#arrow-rust` channels in the [ASF Slack workspace](https://s.apache.org/slack-invite) . | |||
There was a problem hiding this comment.
I have just renamed the slack channel to match this documentation change
Co-authored-by: Andy Grove <andygrove73@gmail.com>
Co-authored-by: Andy Grove <andygrove73@gmail.com>
Co-authored-by: Andy Grove <andygrove73@gmail.com>
|
Thanks for the review @andygrove |
comphead
changed the title
alamb
approved these changes
Apr 23, 2024
| @@ -223,7 +223,7 @@ Here is my vote: | |||
| +1 | |||
|
|
|||
| [1]: https://github.com/apache/datafusion/tree/a5dd428f57e62db20a945e8b1895de91405958c4 | |||
| [2]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.1.0 | |||
| [2]: https://dist.apache.org/repos/dist/dev/arrow/apache-datafusion-5.1.0 | |||
There was a problem hiding this comment.
This isn't quite right (this path doesn't exist) but I think it will be fixed when we update the release scripts
|
Thanks all for the review 👍 |
ccciudatu
pushed a commit
to hstack/arrow-datafusion
that referenced
this pull request
Apr 26, 2024
* fix docs on datafusion names * fix code * fmt * Update dev/release/README.md Co-authored-by: Andy Grove <andygrove73@gmail.com> * Update dev/release/README.md Co-authored-by: Andy Grove <andygrove73@gmail.com> * Update dev/release/README.md Co-authored-by: Andy Grove <andygrove73@gmail.com> --------- Co-authored-by: Andy Grove <andygrove73@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?