proto: don't include parquet feature by default #17577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
proto-default-features
branch
from
5902fea to
5d6dcad
Compare
|
Thanks @jackkleeman -- sounds like a good idea to me. Can you please fix the CI test so we can merge it? |
jackkleeman
force-pushed
the
proto-default-features
branch
from
5d6dcad to
6657c27
Compare
jackkleeman
force-pushed
the
proto-default-features
branch
from
6657c27 to
c26d336
Compare
jackkleeman
changed the title
|
done @alamb |
|
I put it in the merge queue, but we are currently having some issues with the required check validstion |
Jefffrey
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parquet feature from datafusion is pretty heavy and is only needed if the parquet feature flag on proto is on