feat(substrait): add time literal support #17655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for `ScalarValue::Time64Microsecond` and `ScalarValue::Time64Nanosecond` to be converted to and from Substrait literals. This includes the `PrecisionTime` literal type and specific `TIME_64_TYPE_VARIATION_REF` for 6-digit (microseconds) and 9-digit (nanoseconds) precision.
|
@LiaCastaneda and @gabotechs can one of you help review this PR? |
|
Sure! giving it a look shortly |
gabotechs
approved these changes
Sep 19, 2025
| }, | ||
| Some(LiteralType::Date(d)) => ScalarValue::Date32(Some(*d)), | ||
| Some(LiteralType::PrecisionTime(pt)) => match pt.precision { | ||
| 6 => match lit.type_variation_reference { |
There was a problem hiding this comment.
Nice, I imagine if we wanted to support the rest of the type variations it would look something like:
0 => match lit.type_variation_reference {
TIME_32_TYPE_VARIATION_REF => {
ScalarValue::Time32Second(Some(pt.value as i32))
}
others => {
return substrait_err!("Unknown type variation reference {others}");
}
},
3 => match lit.type_variation_reference {
TIME_32_TYPE_VARIATION_REF => {
ScalarValue::Time32Millisecond(Some(pt.value as i32))
}
others => {
return substrait_err!("Unknown type variation reference {others}");
}
},If you are up for the ride I think we could also add them, otherwise I think it's fine as is
There was a problem hiding this comment.
Thanks @gabotechs -- I filed a ticket to track this:
There was a problem hiding this comment.
And @petern48 delivers a PR:
alamb
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Making sure that we can have proper mapping between Substrait and Arrow types.
What changes are included in this PR?
Adds support for
ScalarValue::Time64MicrosecondandScalarValue::Time64Nanosecondto be converted to and from Substrait literals.This includes the
PrecisionTimeliteral type and specificTIME_64_TYPE_VARIATION_REFfor 6-digit (microseconds) and 9-digit (nanoseconds) precision.Are these changes tested?
Added unit tests
Are there any user-facing changes?
n/a