-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to arrow 21 #3225
Upgrade to arrow 21 #3225
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
==========================================
- Coverage 85.95% 85.74% -0.21%
==========================================
Files 294 294
Lines 53560 53738 +178
==========================================
+ Hits 46037 46078 +41
- Misses 7523 7660 +137
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@andygrove @alamb @tustvold I wanted to ping you just in case this is useful to you. I accidentally had this working against master too, so there's build fixes in the commit log of this branch for Arrow 22 if you need those at some point. |
Also, for some reason, github doesn't seem to be pulling commits from this branch anymore and running CI on them. It's been 3 commits to the source branch since tests were run. I'm not sure why that would be. |
Okay, CI is caught up, this is ready for merge as soon as Arrow 21 goes out. |
@avantgardnerio Arrow 21.0.0 is released now. Do you want to update this PR to point to the release so we can merge? |
36f9e45
to
f13407c
Compare
@andygrove GTG |
@@ -513,7 +513,7 @@ mod roundtrip_tests { | |||
DataType::FixedSizeBinary(1234), | |||
DataType::FixedSizeBinary(-432), | |||
DataType::LargeBinary, | |||
DataType::Decimal128(1345, 5431), | |||
DataType::Decimal128(123, 234), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We store precision as a u8 now. 234 fits, 455 doesn't.
Benchmark runs are scheduled for baseline = a32c408 and contender = fcd2275. fcd2275 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Thank you for this @avantgardnerio 🙏 |
Which issue does this PR close?
Closes #3224.
Rationale for this change
We have to track the latest arrow-rs, or DataFusion becomes less appealing for users.
What changes are included in this PR?
Fix build for breaking changes in arrow 21.
Are there any user-facing changes?
No