Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "IS NOT TRUE/FALSE" syntax #3252

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

sarahyurick
Copy link
Contributor

Which issue does this PR close?

Closes #2265

What changes are included in this PR?

Similar to #3235 and #3246, this PR adds the "IS NOT TRUE" and "IS NOT FALSE" boolean operations and their SQL-level tests.

@github-actions github-actions bot added core Core DataFusion crate sql SQL Planner labels Aug 24, 2022
@sarahyurick
Copy link
Contributor Author

@andygrove this should also be included in #3247

@codecov-commenter
Copy link

Codecov Report

Merging #3252 (b78a756) into master (94dacce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3252   +/-   ##
=======================================
  Coverage   85.85%   85.86%           
=======================================
  Files         293      293           
  Lines       53284    53322   +38     
=======================================
+ Hits        45747    45784   +37     
- Misses       7537     7538    +1     
Impacted Files Coverage Δ
datafusion/core/tests/sql/expr.rs 99.86% <100.00%> (+<0.01%) ⬆️
datafusion/sql/src/planner.rs 80.66% <100.00%> (+0.07%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 78.21% <0.00%> (-0.35%) ⬇️
datafusion/common/src/scalar.rs 84.65% <0.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = bcb660e and contender = 2de77fb. 2de77fb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "IS NOT TRUE/FALSE" syntax
4 participants