Skip to content

Conversation

jmalkin
Copy link
Contributor

@jmalkin jmalkin commented Jul 1, 2021

Expanded test margins for relative accuracy python tests by about 50%, for all provided variants of quantiles sketches.

The original margins are generally ok, but we're using random data in the tests (which also function as documentation/tutorials) and don't have a way to make the structures deterministic even for testing. As a result, we end up with the expected real-world "failures" due to low probability events showing up eventually. We have enough independent tests that it's not surprising that one of them is outside the stated tolerance every so often.

The non-quantiles sketches do not have this issue and are unchanged.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 991414770

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.76%

Totals Coverage Status
Change from base Build 991138921: 0.0%
Covered Lines: 2178
Relevant Lines: 2348

💛 - Coveralls

@jmalkin jmalkin requested a review from AlexanderSaydakov July 1, 2021 20:33
@jmalkin jmalkin merged commit dc24f84 into master Jul 1, 2021
@jmalkin jmalkin deleted the py_tolerance branch July 1, 2021 22:35
@coveralls
Copy link

coveralls commented Nov 23, 2024

Pull Request Test Coverage Report for Build 991414770

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.927%

Totals Coverage Status
Change from base Build 991138921: 0.0%
Covered Lines: 7415
Relevant Lines: 7572

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants