adjust python test tolerances #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded test margins for relative accuracy python tests by about 50%, for all provided variants of quantiles sketches.
The original margins are generally ok, but we're using random data in the tests (which also function as documentation/tutorials) and don't have a way to make the structures deterministic even for testing. As a result, we end up with the expected real-world "failures" due to low probability events showing up eventually. We have enough independent tests that it's not surprising that one of them is outside the stated tolerance every so often.
The non-quantiles sketches do not have this issue and are unchanged.