Skip to content

Disallow setting the TrustManagers to null #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Disallow setting the TrustManagers to null #12

merged 1 commit into from
Jun 18, 2019

Conversation

coheigea
Copy link
Contributor

No description provided.

@coheigea coheigea requested a review from elecharny June 18, 2019 11:25
elecharny
elecharny approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@elecharny elecharny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this approach.

Regardless, there are many places in the server where we use a NoVerificationTrustManagers, and I think we should check that (but it's orthogonal to your patch)

@coheigea coheigea merged commit 9942102 into master Jun 18, 2019
@coheigea coheigea deleted the trustmanagers branch June 18, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elecharny elecharny elecharny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coheigea @elecharny