Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16374][dolphinscheduler-alert] Fix DingTalk replace the atUserIds parameter with atDingtalkIds #16379

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

xxzuo
Copy link
Contributor

@xxzuo xxzuo commented Jul 26, 2024

Purpose of the pull request

fix #16374

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added UI ui and front end related backend labels Jul 26, 2024
@SbloodyS SbloodyS added the bug Something isn't working label Jul 26, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jul 26, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide the screenshot of alert result show and the official documentation url for DingTalk.

@xxzuo
Copy link
Contributor Author

xxzuo commented Aug 9, 2024

Please provide the screenshot of alert result show and the official documentation url for DingTalk.

Perhaps the official documents were not updated in a timely manner. The official documentation still shows the old parameters. But according to other users' blogs, the new parameter should be atDingtalkIds.
guanguans/notify#18
https://www.cnblogs.com/sk-3/p/15411669.html
https://blog.csdn.net/kiossy/article/details/127763502

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

sonarcloud bot commented Aug 12, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@SbloodyS SbloodyS merged commit f9db865 into apache:dev Aug 12, 2024
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-alert] The atUserIds parameter configured in DingTalk is invalid
5 participants