-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16374][dolphinscheduler-alert] Fix DingTalk replace the atUserIds parameter with atDingtalkIds #16379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide the screenshot of alert result show and the official documentation url for DingTalk.
Perhaps the official documents were not updated in a timely manner. The official documentation still shows the old parameters. But according to other users' blogs, the new parameter should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Please retry analysis of this Pull-Request directly on SonarCloud |
Purpose of the pull request
fix #16374
the
atUserIds
parameter is invalidhttps://www.cnblogs.com/sk-3/p/15411669.html
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md