-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](multi-catalog) Support sql cache for hms catalog #23391
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
1189c20
to
d7e5bf1
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
719066a
to
41add2f
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java
Outdated
Show resolved
Hide resolved
cfc57ef
to
1351478
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
I will add test case later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
**Support sql cache for hms catalog. Legacy planner and Nereids planner are all supported. Not support partition cache now, not support federated query now.**
Proposed changes
Issue Number: close #xxx
Support sql cache for hms catalog. Legacy planner and Nereids planner are all supported.
Not support partition cache now, not support federated query now.
Now just use the
lastUpdateTime
of hive table, and the relevant pr is #21873 . The cache will be missed if thelastUpdateTime
changed, i will submit a pr to record the update time of hive partitions later~Test case 1:
Set
Config.cache_last_version_interval_second=1
.select * from test_wxy.call_center limit 10
, wait a second and submit the query again, the cache will hit at the second time.refresh table hive_safelycc.test_wxy.call_center
, then cache will be missed.Test case 2:
Set
Config.cache_last_version_interval_second=1
, enable hms event listener.select count(0) from test_wxy.call_center
, wait a second and submit the query again, the cache will hit at the second time.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...