Skip to content

[fix](be-ut) Missing cache types in BlockFileCacheTest #34227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Apr 28, 2024

Proposed changes

Issue Number: close #xxx

Fix BE UT (macOS). See https://github.com/apache/doris/actions/runs/8864918612/job/24340617696.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147 adonis0147 marked this pull request as draft April 28, 2024 06:47
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@adonis0147 adonis0147 changed the title Draft [fix] Missing cache types in BlockFileCacheTest Apr 28, 2024
@adonis0147 adonis0147 marked this pull request as ready for review April 28, 2024 08:26
@adonis0147
Copy link
Contributor Author

run buildall

@adonis0147 adonis0147 changed the title [fix] Missing cache types in BlockFileCacheTest [fix](be-ut) Missing cache types in BlockFileCacheTest Apr 28, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.49% (8924/25145)
Line Coverage: 27.14% (73475/270706)
Region Coverage: 26.33% (37956/144162)
Branch Coverage: 23.11% (19328/83624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c96b4a12a77f09d78fcaf7a8e928a7071929affd_c96b4a12a77f09d78fcaf7a8e928a7071929affd/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 186190 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c96b4a12a77f09d78fcaf7a8e928a7071929affd, data reload: false

query1	910	346	342	342
query2	6540	2308	2290	2290
query3	6664	208	210	208
query4	25290	21134	21268	21134
query5	4185	413	437	413
query6	272	182	187	182
query7	4597	290	293	290
query8	247	191	196	191
query9	8665	2359	2349	2349
query10	433	236	251	236
query11	14797	14131	14235	14131
query12	131	85	85	85
query13	1633	357	363	357
query14	10507	7663	8220	7663
query15	250	166	168	166
query16	8134	268	259	259
query17	1858	558	536	536
query18	2071	269	265	265
query19	191	156	151	151
query20	92	87	88	87
query21	191	135	128	128
query22	5041	4869	4854	4854
query23	33856	33144	33168	33144
query24	10952	2998	2985	2985
query25	619	365	368	365
query26	1170	153	150	150
query27	2890	323	337	323
query28	7454	2026	2039	2026
query29	855	596	589	589
query30	295	149	151	149
query31	960	773	698	698
query32	93	52	52	52
query33	739	249	245	245
query34	1097	491	483	483
query35	815	679	666	666
query36	1084	876	938	876
query37	142	66	67	66
query38	3121	2971	2991	2971
query39	1612	1550	1498	1498
query40	199	128	126	126
query41	43	39	38	38
query42	105	94	96	94
query43	553	517	520	517
query44	1218	713	724	713
query45	279	257	263	257
query46	1072	725	723	723
query47	1970	1851	1917	1851
query48	357	301	309	301
query49	1096	408	407	407
query50	774	396	386	386
query51	6720	6572	6650	6572
query52	112	87	90	87
query53	349	282	282	282
query54	306	245	246	245
query55	79	74	73	73
query56	244	235	225	225
query57	1198	1130	1114	1114
query58	223	198	204	198
query59	3368	3211	3254	3211
query60	279	254	244	244
query61	110	109	110	109
query62	666	432	450	432
query63	304	279	283	279
query64	8693	7215	7193	7193
query65	3116	3052	3031	3031
query66	1397	355	345	345
query67	15897	14916	14947	14916
query68	7584	554	556	554
query69	555	315	313	313
query70	1184	1139	1041	1041
query71	487	274	270	270
query72	7954	2712	2399	2399
query73	730	326	329	326
query74	6506	6128	6111	6111
query75	4100	2652	2599	2599
query76	4768	904	975	904
query77	632	283	259	259
query78	11183	10335	10334	10334
query79	13002	524	525	524
query80	1768	436	434	434
query81	520	224	221	221
query82	794	92	94	92
query83	208	186	164	164
query84	269	86	84	84
query85	1411	272	262	262
query86	417	279	295	279
query87	3353	3132	3087	3087
query88	5226	2413	2419	2413
query89	529	373	371	371
query90	1997	184	185	184
query91	130	99	100	99
query92	65	48	48	48
query93	7465	521	510	510
query94	1216	190	185	185
query95	409	302	308	302
query96	599	263	265	263
query97	3158	2962	2921	2921
query98	239	219	213	213
query99	1303	871	852	852
Total cold run time: 310941 ms
Total hot run time: 186190 ms

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 28, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@adonis0147 adonis0147 merged commit 7d61030 into apache:master Apr 28, 2024
@adonis0147 adonis0147 deleted the be-ut branch April 28, 2024 12:15
dataroaring pushed a commit that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants