[fix](mtmv) Fix materialized rewrite oom when the num of relation mapping is too large #48887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 32236 ms |
TPC-DS: Total hot run time: 192253 ms |
ClickBench: Total hot run time: 30.62 s |
seawinde
changed the title
morrySnow
reviewed
Mar 18, 2025
| boolean[] used, MappedRelation[] current, List<Pair<MappedRelation[], MappedRelation[]>> results, | ||
| int maxMappingCount) { | ||
| if (results.size() >= maxMappingCount) { | ||
| LOG.warn("queryToViewTableMappings is over limit and be intercepted"); |
There was a problem hiding this comment.
log size and other key info here
seawinde
force-pushed
the
fix_relation_mapping_oom
branch
from
718fc16 to
61ff18d
Compare
|
run buildall |
TPC-H: Total hot run time: 32610 ms |
TPC-DS: Total hot run time: 192447 ms |
ClickBench: Total hot run time: 30.97 s |
morrySnow
reviewed
Mar 19, 2025
Comment on lines
202
to
204
| LOG.warn(String.format("queryToViewTableMappings is over limit and be intercepted, " | ||
| + "results size is %s,\n MappedRelation left is %s,\n MappedRelation right is %s \n", | ||
| results.size(), Arrays.toString(left), Arrays.toString(right))); |
There was a problem hiding this comment.
do not use String.format use log place holder instead. do not use \n in log normally, because it is not friendly for auto log analysis
Suggested change
| LOG.warn(String.format("queryToViewTableMappings is over limit and be intercepted, " | |
| + "results size is %s,\n MappedRelation left is %s,\n MappedRelation right is %s \n", | |
| results.size(), Arrays.toString(left), Arrays.toString(right))); | |
| LOG.warn("queryToViewTableMappings is over limit and be intercepted, " | |
| + "results size is {}, MappedRelation left is {}, MappedRelation right is {}", | |
| results.size(), left, right); |
|
run buildall |
TPC-H: Total hot run time: 32710 ms |
TPC-DS: Total hot run time: 185973 ms |
ClickBench: Total hot run time: 31.26 s |
seawinde
force-pushed
the
fix_relation_mapping_oom
branch
from
034451b to
6592ea6
Compare
|
run buildall |
TPC-H: Total hot run time: 32114 ms |
TPC-DS: Total hot run time: 192356 ms |
ClickBench: Total hot run time: 30.82 s |
|
PR approved by anyone and no changes requested. |
seawinde
force-pushed
the
fix_relation_mapping_oom
branch
from
e3ea000 to
c801da8
Compare
|
run buildall |
TPC-H: Total hot run time: 35606 ms |
TPC-DS: Total hot run time: 192989 ms |
ClickBench: Total hot run time: 31.87 s |
|
run buildall |
TPC-H: Total hot run time: 33953 ms |
TPC-DS: Total hot run time: 193095 ms |
ClickBench: Total hot run time: 30.86 s |
morrySnow
approved these changes
Apr 2, 2025
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
…ping is too large (#48887) ### What problem does this PR solve? Fix materialized rewrite oom when the num of relation mapping is two large In a database query with 10 self-joins on the same table, there would be 10! = 3,628,800 unique permutation combinations. These need to be pruned in advance through query optimization to avoid excessive memory consumption
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Apr 7, 2025
…ping is too large (apache#48887) Fix materialized rewrite oom when the num of relation mapping is two large In a database query with 10 self-joins on the same table, there would be 10! = 3,628,800 unique permutation combinations. These need to be pruned in advance through query optimization to avoid excessive memory consumption
16 tasks
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ping is too large (apache#48887) ### What problem does this PR solve? Fix materialized rewrite oom when the num of relation mapping is two large In a database query with 10 self-joins on the same table, there would be 10! = 3,628,800 unique permutation combinations. These need to be pruned in advance through query optimization to avoid excessive memory consumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix materialized rewrite oom when the num of relation mapping is two large
In a database query with 10 self-joins on the same table, there would be 10! = 3,628,800 unique permutation combinations. These need to be pruned in advance through query optimization to avoid excessive memory consumption
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
Fix materialized rewrite oom when the num of relation mapping is two large
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)