Skip to content

[Fix](cloud-mow) Handle tablet delete bitmap calculation task's return value unifiedly in CloudEngineCalcDeleteBitmapTask::execute #50019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

[Fix](cloud-mow) Handle tablet delete bitmap calculation task's return value unifiedly in CloudEngineCalcDeleteBitmapTask::execute #50019

merged 2 commits into from
Apr 15, 2025

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Apr 14, 2025 •
edited
Loading

What problem does this PR solve?

handle tablet delete bitmap calculation task's return value in CloudEngineCalcDeleteBitmapTask::execute() unifiedly rather than in the inner functions to avoid some branches' errors from being improperly handled and cause correnct problem.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1 bobhan1 force-pushed the fix-fail-path-in-handle-rowset branch 2 times, most recently from 00aedb0 to 56457b1 Compare April 14, 2025 06:25
@bobhan1 bobhan1 marked this pull request as ready for review April 14, 2025 06:25
@bobhan1 bobhan1 force-pushed the fix-fail-path-in-handle-rowset branch from 56457b1 to 5173442 Compare April 14, 2025 06:27
@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 14, 2025

run buildall

zhannngchen
zhannngchen reviewed Apr 14, 2025
View reviewed changes
@bobhan1 bobhan1 force-pushed the fix-fail-path-in-handle-rowset branch from a7c097c to c3cfbf9 Compare April 14, 2025 07:28
@bobhan1 bobhan1 requested a review from zhannngchen April 14, 2025 07:29
@doris-robot
Copy link

TPC-H: Total hot run time: 34567 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a7c097cc84998813d518afa6af8a785bbcd838a4, data reload: false

------ Round 1 ----------------------------------
q1	26156	5104	5278	5104
q2	2074	292	191	191
q3	10381	1238	709	709
q4	10231	997	533	533
q5	7540	2466	2363	2363
q6	199	171	134	134
q7	904	761	634	634
q8	9336	1364	1168	1168
q9	6800	5100	5105	5100
q10	6802	2302	1897	1897
q11	464	284	273	273
q12	350	359	221	221
q13	17775	3703	3115	3115
q14	222	232	219	219
q15	530	476	499	476
q16	632	618	578	578
q17	591	866	372	372
q18	7657	7321	7219	7219
q19	1093	969	592	592
q20	345	338	225	225
q21	3981	3319	2484	2484
q22	1037	1006	960	960
Total cold run time: 115100 ms
Total hot run time: 34567 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5133	5180	5105	5105
q2	241	333	236	236
q3	2151	2691	2279	2279
q4	1477	1876	1497	1497
q5	4621	4469	4389	4389
q6	209	163	128	128
q7	1985	1896	1808	1808
q8	2576	2513	2588	2513
q9	7114	7131	7064	7064
q10	3009	3195	2735	2735
q11	580	515	494	494
q12	714	777	608	608
q13	3543	3886	3340	3340
q14	276	294	267	267
q15	530	473	471	471
q16	665	673	660	660
q17	1158	1556	1426	1426
q18	7877	7585	7437	7437
q19	878	881	955	881
q20	1960	2003	1895	1895
q21	5230	4697	4632	4632
q22	1049	1060	951	951
Total cold run time: 52976 ms
Total hot run time: 50816 ms

@bobhan1 bobhan1 force-pushed the fix-fail-path-in-handle-rowset branch from c3cfbf9 to 3975d23 Compare April 14, 2025 07:33
zhannngchen
zhannngchen reviewed Apr 14, 2025
View reviewed changes
@doris-robot
Copy link

TPC-DS: Total hot run time: 186469 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a7c097cc84998813d518afa6af8a785bbcd838a4, data reload: false

query1	1024	488	504	488
query2	6524	1905	1881	1881
query3	6765	218	220	218
query4	26271	23693	23508	23508
query5	4312	630	449	449
query6	304	199	189	189
query7	4613	486	279	279
query8	285	245	238	238
query9	8621	2592	2585	2585
query10	443	326	263	263
query11	15358	15033	15015	15015
query12	160	111	109	109
query13	1656	513	400	400
query14	9129	6361	6156	6156
query15	210	193	170	170
query16	7145	649	469	469
query17	1018	731	579	579
query18	1988	408	318	318
query19	198	192	165	165
query20	128	127	123	123
query21	220	124	105	105
query22	4112	4139	4148	4139
query23	34012	33018	32925	32925
query24	8432	2398	2404	2398
query25	542	452	445	445
query26	1250	267	149	149
query27	2771	497	327	327
query28	4327	2406	2418	2406
query29	748	552	424	424
query30	287	207	192	192
query31	924	873	748	748
query32	82	65	62	62
query33	594	380	311	311
query34	790	858	505	505
query35	770	811	748	748
query36	977	980	884	884
query37	118	100	81	81
query38	4100	4237	4116	4116
query39	1458	1410	1396	1396
query40	229	125	106	106
query41	56	54	52	52
query42	121	105	105	105
query43	491	499	491	491
query44	1292	811	800	800
query45	181	175	170	170
query46	822	1021	620	620
query47	1732	1774	1710	1710
query48	379	418	290	290
query49	783	492	420	420
query50	634	666	391	391
query51	4180	4142	4097	4097
query52	114	109	100	100
query53	221	259	189	189
query54	574	580	517	517
query55	87	82	82	82
query56	298	307	283	283
query57	1101	1145	1063	1063
query58	274	250	250	250
query59	2577	2639	2586	2586
query60	334	324	310	310
query61	136	131	123	123
query62	789	747	669	669
query63	225	186	182	182
query64	4369	1009	691	691
query65	4340	4235	4279	4235
query66	1158	410	313	313
query67	15621	15568	15294	15294
query68	7809	867	515	515
query69	468	300	263	263
query70	1177	1087	1106	1087
query71	410	333	292	292
query72	5644	4748	4871	4748
query73	681	625	338	338
query74	9220	9077	8716	8716
query75	3456	3273	2691	2691
query76	3367	1191	754	754
query77	727	389	287	287
query78	9899	10033	9212	9212
query79	2468	820	554	554
query80	633	500	439	439
query81	508	261	217	217
query82	516	125	97	97
query83	259	248	228	228
query84	286	101	86	86
query85	834	355	317	317
query86	385	309	258	258
query87	4511	4486	4367	4367
query88	3842	2196	2195	2195
query89	385	313	292	292
query90	1862	204	209	204
query91	147	143	110	110
query92	79	58	58	58
query93	2100	945	582	582
query94	676	418	314	314
query95	370	288	282	282
query96	481	564	272	272
query97	3166	3350	3071	3071
query98	235	211	198	198
query99	1381	1408	1323	1323
Total cold run time: 273766 ms
Total hot run time: 186469 ms

@bobhan1 bobhan1 force-pushed the fix-fail-path-in-handle-rowset branch from 3975d23 to 4197d0d Compare April 14, 2025 07:47
@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a7c097cc84998813d518afa6af8a785bbcd838a4, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.11	0.11
query3	0.26	0.19	0.20
query4	1.59	0.19	0.20
query5	0.59	0.59	0.58
query6	1.18	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.59	0.55	0.50
query10	0.57	0.57	0.56
query11	0.16	0.10	0.10
query12	0.14	0.11	0.12
query13	0.63	0.59	0.60
query14	2.70	2.82	2.73
query15	0.90	0.85	0.85
query16	0.39	0.38	0.39
query17	1.05	1.03	1.07
query18	0.20	0.19	0.19
query19	1.89	1.93	1.83
query20	0.02	0.01	0.01
query21	15.34	0.90	0.54
query22	0.75	1.11	0.69
query23	15.02	1.39	0.66
query24	6.92	1.60	0.32
query25	0.31	0.12	0.15
query26	0.66	0.16	0.14
query27	0.06	0.05	0.04
query28	9.47	0.94	0.42
query29	12.53	3.99	3.33
query30	0.25	0.09	0.06
query31	2.82	0.61	0.39
query32	3.23	0.54	0.47
query33	2.98	3.03	3.06
query34	15.76	5.08	4.49
query35	4.55	4.52	4.48
query36	0.66	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.13
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.88 s
Total hot run time: 30.73 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 14, 2025

run buildall

zhannngchen
zhannngchen previously approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@bobhan1 bobhan1 force-pushed the fix-fail-path-in-handle-rowset branch from 4197d0d to c900059 Compare April 14, 2025 08:12
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 14, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 33819 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4197d0d998f960dd53885a2e7ac3d5200d6585c3, data reload: false

------ Round 1 ----------------------------------
q1	26230	5040	5127	5040
q2	2105	285	186	186
q3	10383	1203	686	686
q4	10244	1008	510	510
q5	7541	2364	2316	2316
q6	186	159	131	131
q7	894	729	604	604
q8	9330	1277	988	988
q9	6723	5013	5046	5013
q10	6803	2295	1886	1886
q11	480	276	288	276
q12	360	355	225	225
q13	17787	3653	3135	3135
q14	229	219	203	203
q15	548	489	476	476
q16	615	628	608	608
q17	594	836	373	373
q18	7593	7315	7064	7064
q19	2539	946	543	543
q20	335	332	219	219
q21	3859	2658	2399	2399
q22	1031	992	938	938
Total cold run time: 116409 ms
Total hot run time: 33819 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5232	5092	5151	5092
q2	250	334	228	228
q3	2171	2649	2295	2295
q4	1426	1786	1417	1417
q5	4499	4477	4407	4407
q6	210	172	131	131
q7	1981	1932	1741	1741
q8	2590	2474	2488	2474
q9	7115	7190	7162	7162
q10	2982	3163	2744	2744
q11	583	513	484	484
q12	709	731	594	594
q13	3461	3845	3234	3234
q14	267	281	258	258
q15	525	470	469	469
q16	672	696	660	660
q17	1139	1548	1376	1376
q18	7607	7559	7345	7345
q19	819	820	801	801
q20	1936	2052	1855	1855
q21	5166	4638	4537	4537
q22	1006	1010	992	992
Total cold run time: 52346 ms
Total hot run time: 50296 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185963 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4197d0d998f960dd53885a2e7ac3d5200d6585c3, data reload: false

query1	1027	487	509	487
query2	6541	1879	1848	1848
query3	6749	222	224	222
query4	26478	23922	23554	23554
query5	4291	610	494	494
query6	319	214	185	185
query7	4632	492	280	280
query8	292	235	233	233
query9	8620	2568	2594	2568
query10	469	311	266	266
query11	15260	15185	14802	14802
query12	152	107	114	107
query13	1668	526	379	379
query14	8667	6129	6115	6115
query15	201	188	162	162
query16	7120	614	473	473
query17	945	700	561	561
query18	1962	396	307	307
query19	188	180	153	153
query20	118	117	108	108
query21	209	123	104	104
query22	3967	4010	4060	4010
query23	33670	32988	32772	32772
query24	8428	2397	2403	2397
query25	542	444	387	387
query26	1241	268	154	154
query27	2750	498	333	333
query28	4421	2428	2382	2382
query29	745	540	459	459
query30	279	221	192	192
query31	930	851	792	792
query32	76	67	68	67
query33	561	376	310	310
query34	784	852	505	505
query35	785	892	774	774
query36	957	973	876	876
query37	116	103	81	81
query38	4124	4198	4019	4019
query39	1437	1423	1403	1403
query40	206	117	106	106
query41	61	53	54	53
query42	125	109	104	104
query43	496	495	472	472
query44	1335	805	798	798
query45	174	176	167	167
query46	826	1004	618	618
query47	1746	1790	1703	1703
query48	371	409	320	320
query49	783	552	450	450
query50	692	662	394	394
query51	4181	4194	4054	4054
query52	110	109	104	104
query53	230	256	183	183
query54	576	584	499	499
query55	85	79	82	79
query56	304	296	285	285
query57	1109	1119	1086	1086
query58	264	257	249	249
query59	2563	2639	2617	2617
query60	322	310	309	309
query61	136	134	128	128
query62	808	741	670	670
query63	228	195	199	195
query64	4541	1036	693	693
query65	4291	4261	4257	4257
query66	1149	410	305	305
query67	15681	15343	14970	14970
query68	5715	905	516	516
query69	485	304	270	270
query70	1168	1096	1120	1096
query71	396	327	300	300
query72	5631	4797	5094	4797
query73	678	637	363	363
query74	9078	9218	8888	8888
query75	3172	3211	2687	2687
query76	3170	1188	773	773
query77	483	405	321	321
query78	10110	10268	9197	9197
query79	2370	813	587	587
query80	628	514	427	427
query81	491	266	227	227
query82	340	132	98	98
query83	267	248	237	237
query84	300	112	91	91
query85	760	449	313	313
query86	384	287	298	287
query87	4526	4433	4374	4374
query88	3710	2251	2198	2198
query89	380	307	289	289
query90	1984	212	212	212
query91	140	142	108	108
query92	87	58	57	57
query93	2515	935	572	572
query94	676	401	305	305
query95	378	280	284	280
query96	488	575	277	277
query97	3098	3216	3134	3134
query98	229	204	201	201
query99	1347	1406	1292	1292
Total cold run time: 270298 ms
Total hot run time: 185963 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.18 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4197d0d998f960dd53885a2e7ac3d5200d6585c3, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.11
query3	0.25	0.19	0.19
query4	1.61	0.18	0.19
query5	0.60	0.58	0.59
query6	1.20	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.55	0.52
query10	0.57	0.59	0.57
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	2.79	2.80	2.82
query15	0.94	0.86	0.86
query16	0.39	0.39	0.38
query17	1.08	1.02	1.02
query18	0.21	0.20	0.19
query19	1.89	1.94	1.86
query20	0.02	0.01	0.01
query21	15.36	0.88	0.58
query22	0.74	1.17	0.64
query23	14.97	1.40	0.61
query24	6.99	0.84	1.13
query25	0.51	0.10	0.07
query26	0.63	0.17	0.13
query27	0.05	0.06	0.05
query28	10.20	0.90	0.42
query29	12.63	3.96	3.32
query30	0.25	0.09	0.06
query31	2.84	0.59	0.40
query32	3.22	0.54	0.46
query33	3.00	3.02	3.10
query34	15.68	5.09	4.46
query35	4.53	4.49	4.47
query36	0.66	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.03
query40	0.18	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.03 s
Total hot run time: 31.18 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 14, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34194 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c9000596dd2a41bf6ccbf40d62f935e1f72a625b, data reload: false

------ Round 1 ----------------------------------
q1	25896	5093	5027	5027
q2	2067	285	182	182
q3	10395	1230	707	707
q4	10227	1007	527	527
q5	7495	2380	2370	2370
q6	194	164	137	137
q7	937	766	626	626
q8	9325	1279	1131	1131
q9	6787	5130	5072	5072
q10	6841	2291	1886	1886
q11	475	275	265	265
q12	344	352	212	212
q13	17752	3665	3059	3059
q14	232	227	211	211
q15	529	484	482	482
q16	651	616	598	598
q17	591	872	365	365
q18	7650	7296	7130	7130
q19	1208	974	586	586
q20	340	332	226	226
q21	3997	3326	2454	2454
q22	1027	995	941	941
Total cold run time: 114960 ms
Total hot run time: 34194 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5129	5142	5085	5085
q2	241	356	237	237
q3	2130	2666	2248	2248
q4	1411	1788	1365	1365
q5	4545	4513	4444	4444
q6	219	166	128	128
q7	1935	1886	1749	1749
q8	2636	2525	2585	2525
q9	7194	7131	7274	7131
q10	2974	3194	2715	2715
q11	576	503	543	503
q12	709	734	623	623
q13	3389	3898	3306	3306
q14	274	283	270	270
q15	520	481	473	473
q16	672	685	638	638
q17	1202	1633	1400	1400
q18	7963	7542	7463	7463
q19	822	823	853	823
q20	1918	2045	1844	1844
q21	5125	4600	4605	4600
q22	1032	1017	967	967
Total cold run time: 52616 ms
Total hot run time: 50537 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186017 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c9000596dd2a41bf6ccbf40d62f935e1f72a625b, data reload: false

query1	1027	476	523	476
query2	6544	1888	1869	1869
query3	6739	215	218	215
query4	26011	23693	23092	23092
query5	4362	633	487	487
query6	284	198	177	177
query7	4615	490	272	272
query8	284	246	233	233
query9	8635	2586	2602	2586
query10	483	322	272	272
query11	15664	15007	14818	14818
query12	158	112	103	103
query13	1661	524	397	397
query14	8843	6140	6213	6140
query15	198	186	169	169
query16	7202	635	486	486
query17	1187	709	549	549
query18	1959	397	286	286
query19	183	178	181	178
query20	118	119	123	119
query21	222	128	105	105
query22	3979	4116	4078	4078
query23	33615	32850	32905	32850
query24	8435	2363	2375	2363
query25	541	453	393	393
query26	1237	261	152	152
query27	2761	502	334	334
query28	4341	2398	2372	2372
query29	759	550	418	418
query30	288	245	191	191
query31	919	862	732	732
query32	75	67	64	64
query33	560	353	343	343
query34	798	860	502	502
query35	799	828	745	745
query36	935	1002	871	871
query37	141	100	76	76
query38	4088	4080	4129	4080
query39	1446	1403	1544	1403
query40	220	117	102	102
query41	58	56	53	53
query42	119	106	101	101
query43	501	502	484	484
query44	1274	795	788	788
query45	175	178	169	169
query46	827	1013	624	624
query47	1770	1803	1741	1741
query48	368	418	308	308
query49	791	498	419	419
query50	647	670	398	398
query51	4147	4197	4200	4197
query52	110	114	98	98
query53	221	251	186	186
query54	573	569	520	520
query55	85	82	78	78
query56	298	300	287	287
query57	1155	1132	1079	1079
query58	271	268	247	247
query59	2503	2667	2553	2553
query60	337	348	316	316
query61	154	147	150	147
query62	798	725	667	667
query63	218	190	198	190
query64	4455	1110	742	742
query65	4299	4264	4189	4189
query66	1146	411	306	306
query67	15719	15521	15283	15283
query68	7977	881	509	509
query69	471	306	262	262
query70	1175	1109	1125	1109
query71	454	309	295	295
query72	5583	4843	4840	4840
query73	744	656	339	339
query74	8908	9111	8962	8962
query75	3755	3195	2655	2655
query76	3661	1184	745	745
query77	784	381	332	332
query78	10050	10163	9155	9155
query79	2528	817	560	560
query80	612	497	438	438
query81	492	263	226	226
query82	465	127	99	99
query83	292	248	227	227
query84	300	103	82	82
query85	807	349	315	315
query86	387	308	310	308
query87	4461	4437	4366	4366
query88	3295	2237	2235	2235
query89	385	310	276	276
query90	1826	212	215	212
query91	145	143	115	115
query92	83	67	57	57
query93	1784	938	580	580
query94	666	421	293	293
query95	371	283	285	283
query96	481	567	271	271
query97	3214	3220	3118	3118
query98	230	209	208	208
query99	1432	1417	1277	1277
Total cold run time: 273153 ms
Total hot run time: 186017 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.15 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c9000596dd2a41bf6ccbf40d62f935e1f72a625b, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.25	0.19	0.20
query4	1.60	0.19	0.11
query5	0.57	0.56	0.55
query6	1.19	0.72	0.72
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.52	0.51
query10	0.56	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.59	0.59
query14	2.68	2.70	2.69
query15	0.91	0.84	0.86
query16	0.38	0.39	0.39
query17	0.99	1.07	1.02
query18	0.21	0.20	0.20
query19	1.96	1.93	1.80
query20	0.02	0.01	0.02
query21	15.35	0.88	0.56
query22	0.76	1.22	0.80
query23	14.71	1.40	0.64
query24	7.03	1.45	0.73
query25	0.51	0.26	0.15
query26	0.61	0.17	0.14
query27	0.06	0.05	0.05
query28	9.25	0.85	0.43
query29	12.53	3.99	3.35
query30	0.24	0.09	0.06
query31	2.83	0.59	0.40
query32	3.22	0.55	0.46
query33	3.01	3.01	3.09
query34	15.59	5.13	4.49
query35	4.50	4.53	4.49
query36	0.65	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 104.36 s
Total hot run time: 31.15 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/14) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.49% (14111/26883)
Line Coverage 41.28% (121981/295473)
Region Coverage 40.05% (62135/155153)
Branch Coverage 34.69% (31101/89664)

@bobhan1
Copy link
Contributor Author

bobhan1 commented Apr 14, 2025

run p0

zhannngchen
zhannngchen approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@bobhan1 bobhan1 changed the title [Fix](cloud-mow) Handle fail path correctly in CloudTabletCalcDeleteBitmapTask [Fix](cloud-mow) Handle tablet delete bitmap calculation task's return value unifiedly in CloudEngineCalcDeleteBitmapTask::execute Apr 14, 2025
dataroaring
dataroaring approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 50fcd2e into apache:master Apr 15, 2025
31 of 32 checks passed
@bobhan1 bobhan1 mentioned this pull request Apr 15, 2025
Merged
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
@bobhan1 @seawinde
[Fix](cloud-mow) Handle tablet delete bitmap calculation task's retur…
e945e00 
…n value unifiedly in `CloudEngineCalcDeleteBitmapTask::execute` (apache#50019)

### What problem does this PR solve?
handle tablet delete bitmap calculation task's return value in
`CloudEngineCalcDeleteBitmapTask::execute()` unifiedly rather than in
the inner functions to avoid some branches' errors from being improperly
handled and cause correnct problem.
dataroaring pushed a commit that referenced this pull request Apr 22, 2025
@bobhan1
branch-3.0-pick: [Fix](cloud-mow) Handle tablet delete bitmap calcula…
a2a87f2 
…tion task's return value unifiedly in CloudEngineCalcDeleteBitmapTask::execute #50019 (#50045)

pick #50019
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@bobhan1 @koarz
[Fix](cloud-mow) Handle tablet delete bitmap calculation task's retur…
1f860f6 
…n value unifiedly in `CloudEngineCalcDeleteBitmapTask::execute` (apache#50019)

### What problem does this PR solve?
handle tablet delete bitmap calculation task's return value in
`CloudEngineCalcDeleteBitmapTask::execute()` unifiedly rather than in
the inner functions to avoid some branches' errors from being improperly
handled and cause correnct problem.
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.6-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobhan1 @Thearas @doris-robot @zhannngchen @dataroaring