branch-3.0: [fix](transaction) remove visible rowset from memory during deletion transaction #50066 #50103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…transaction (#50066) ### What problem does this PR solve? Repeatedly reporting errors in the log: ``` W20250415 17:54:01.151019 218169 storage_engine.cpp:785] failed to clear transaction. txn_id=1002, partition_id=1744709709398, tablet_id=1744709709485, status=[E-228]could not delete transaction from engine, just remove it from memory not delete from disk, because related rowset already published. partition_id: 1744709709398, transaction_id: 1002, tablet: 1744709709485.fb491f2a6f29dad0-28fe3fdfba3272b5, rowset id: 020000000000001fc6430de53121366b7d7bc36d82a1ae92, version: [2-2], state: VISIBLE W20250415 17:54:01.152154 218169 storage_engine.cpp:785] failed to clear transaction. txn_id=1002, partition_id=1744709709398, tablet_id=1744709709493, status=[E-228]could not delete transaction from engine, just remove it from memory not delete from disk, because related rowset already published. partition_id: 1744709709398, transaction_id: 1002, tablet: 1744709709493.7a47a3bf7dcc70f0-353230158f6c2390, rowset id: 0200000000000019c6430de53121366b7d7bc36d82a1ae92, version: [2-2], state: VISIBLE W20250415 17:54:01.152177 218169 storage_engine.cpp:785] failed to clear transaction. txn_id=1002, partition_id=1744709709398, tablet_id=1744709709509, status=[E-228]could not delete transaction from engine, just remove it from memory not delete from disk, because related rowset already published. partition_id: 1744709709398, transaction_id: 1002, tablet: 1744709709509.7f49efdb3b6c2c1d-ed627da9d22c9884, rowset id: 020000000000001bc6430de53121366b7d7bc36d82a1ae92, version: [2-2], state: VISIBLE ``` This bug can occur in the following scenarios: 1. After load the three replicas of the table, the publish task failed after making the rowset as visible in one of the replica. 2. The transactions became visible. Then FE clear visible transaction. 3. The BE node that fails to publish will not delete the memory transaction and report it to FE. FE cannot find the transaction and issues a clear command. However, the deletion fails due to the rowset already published.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 39842 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 196125 ms |
ClickBench: Total hot run time: 33.34 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #50066