[enhancement](cloud) optimize warm up local IO and performance #50275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check whether the data exists based on the cache metadata. If it exists, there is no need to read from the local file, which enhances warm-up performance and reduces disk I/O load. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
|
run buildall |
gavinchou
reviewed
Apr 22, 2025
| @@ -45,6 +45,8 @@ namespace doris::io { | |||
| bvar::Adder<uint64_t> s3_read_counter("cached_remote_reader_s3_read"); | |||
| bvar::LatencyRecorder g_skip_cache_num("cached_remote_reader_skip_cache_num"); | |||
| bvar::Adder<uint64_t> g_skip_cache_sum("cached_remote_reader_skip_cache_sum"); | |||
| bvar::Adder<uint64_t> g_skip_local_cache_io_sum_bytes( | |||
| "cached_remote_reader_skip_local_cache_io_sum_bytes"); | |||
There was a problem hiding this comment.
suggest naming
cached_remote_reader_skip_local_cache_io_bytes
There was a problem hiding this comment.
add sum will underline its cumulative attribute
gavinchou
reviewed
Apr 22, 2025
| @@ -229,6 +230,7 @@ void FileCacheBlockDownloader::download_segment_file(const DownloadFileMeta& met | |||
| // TODO(plat1ko): | |||
| // 1. Directly append buffer data to file cache | |||
| // 2. Provide `FileReader::async_read()` interface | |||
| meta.ctx.is_dryrun = true; | |||
There was a problem hiding this comment.
why meta.is_dryrun is not set by the caller?
There was a problem hiding this comment.
too many of them and is safer to set here.
There was a problem hiding this comment.
I'll set it by caller and use DCHECK here to ensure safety
gavinchou
reviewed
Apr 22, 2025
| @@ -110,6 +112,7 @@ std::pair<size_t, size_t> CachedRemoteFileReader::s_align_size(size_t offset, si | |||
|
|
|||
| Status CachedRemoteFileReader::read_at_impl(size_t offset, Slice result, size_t* bytes_read, | |||
| const IOContext* io_ctx) { | |||
| bool is_dryrun = io_ctx->is_dryrun; | |||
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
|
run buildall |
TPC-H: Total hot run time: 34089 ms |
TPC-DS: Total hot run time: 192694 ms |
ClickBench: Total hot run time: 29.41 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34030 ms |
TPC-DS: Total hot run time: 185687 ms |
ClickBench: Total hot run time: 29.12 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 192550 ms |
ClickBench: Total hot run time: 29.37 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
freemandealer
dismissed stale reviews from dataroaring and gavinchou
via
f775355
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 34290 ms |
TPC-DS: Total hot run time: 192695 ms |
ClickBench: Total hot run time: 29.59 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run p0 |
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Apr 28, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
pingchunzhang
approved these changes
Apr 29, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
Check whether the data exists based on the cache metadata. If it exists, there is no need to read from the local file, which enhances warm-up performance and reduces disk I/O load.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…e#50275) Check whether the data exists based on the cache metadata. If it exists, there is no need to read from the local file, which enhances warm-up performance and reduces disk I/O load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the data exists based on the cache metadata. If it exists, there is no need to read from the local file, which enhances warm-up performance and reduces disk I/O load.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)