[fix](cloud) release fd after clear file cache #50555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
originally, fd is still hold by FDCache after clear file cache (sync) will cause disk space never reaching zero Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer
force-pushed
the
fix-clear-cache-fd-unreleased
branch
from
6fdf686 to
f4ccae6
Compare
|
run buildall |
TPC-H: Total hot run time: 34183 ms |
TPC-DS: Total hot run time: 192162 ms |
ClickBench: Total hot run time: 28.59 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
reviewed
Apr 30, 2025
be/src/io/cache/block_file_cache.cpp
Outdated
| @@ -2077,6 +2077,17 @@ std::string BlockFileCache::clear_file_cache_directly() { | |||
| int64_t normal_queue_size = _normal_queue.get_elements_num(cache_lock); | |||
| int64_t disposible_queue_size = _disposable_queue.get_elements_num(cache_lock); | |||
| int64_t ttl_queue_size = _ttl_queue.get_elements_num(cache_lock); | |||
|
|
|||
| if (config::clear_fd_after_clear_file_cache) { | |||
There was a problem hiding this comment.
no need an extra config, just release them directly after files are deleted.
There was a problem hiding this comment.
in case of performance and robust regression. we can remove this config if it's stable.
There was a problem hiding this comment.
it seems there is no performance problem, line 2069 auto s = _storage->clear(clear_msg); is blocking and time-consuming job before removing FDs.
to avoid too many knobs, keep it simple if the behavior is determined.
we have too many knobs for file cache, too many.
|
run buildall |
TPC-H: Total hot run time: 33926 ms |
TPC-DS: Total hot run time: 184650 ms |
ClickBench: Total hot run time: 29.28 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
|
run buildall |
gavinchou
approved these changes
May 7, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TangSiyang2001
approved these changes
May 7, 2025
TPC-H: Total hot run time: 34534 ms |
TPC-DS: Total hot run time: 192804 ms |
ClickBench: Total hot run time: 29.14 s |
Yukang-Lian
approved these changes
May 7, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
May 8, 2025
gavinchou
approved these changes
May 8, 2025
|
run buildall |
TPC-H: Total hot run time: 34153 ms |
TPC-DS: Total hot run time: 186465 ms |
ClickBench: Total hot run time: 28.88 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run external |
|
run p0 |
|
run external |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
May 14, 2025
originally, fd is still hold by FDCache after clear file cache (sync) will cause disk space never reaching zero Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
dataroaring
pushed a commit
that referenced
this pull request
May 14, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
originally, fd is still hold by FDCache after clear file cache (sync) will cause disk space never reaching zero Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally, fd is still hold by FDCache after clear file cache (sync) will cause disk space never reaching zero
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)