Skip to content

[fix](planner)comparing partition column name should be case insensitive when pruning partition in DeleteJob #50674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

[fix](planner)comparing partition column name should be case insensitive when pruning partition in DeleteJob #50674

merged 1 commit into from
May 21, 2025

Conversation

starocean999
Copy link
Contributor

…

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33819 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01f0b7408988b05e06a76ff289821b60bad8d734, data reload: false

------ Round 1 ----------------------------------
q1	25997	5101	5032	5032
q2	2066	274	175	175
q3	10397	1249	685	685
q4	10238	1000	526	526
q5	7530	2368	2337	2337
q6	183	162	130	130
q7	898	773	634	634
q8	9330	1327	1068	1068
q9	6704	5074	5071	5071
q10	7141	2321	1886	1886
q11	489	313	272	272
q12	351	358	215	215
q13	17791	3709	3095	3095
q14	229	230	210	210
q15	527	477	481	477
q16	426	427	375	375
q17	585	869	370	370
q18	7417	7126	7090	7090
q19	1689	949	551	551
q20	327	333	230	230
q21	4016	3367	2439	2439
q22	1071	1007	951	951
Total cold run time: 115402 ms
Total hot run time: 33819 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5242	5114	5089	5089
q2	247	327	240	240
q3	2164	2669	2275	2275
q4	1365	1784	1396	1396
q5	4440	4408	4470	4408
q6	217	171	126	126
q7	1980	1971	1763	1763
q8	2620	2594	2564	2564
q9	7185	7214	6945	6945
q10	2959	3198	2717	2717
q11	608	508	495	495
q12	685	781	604	604
q13	3516	3895	3368	3368
q14	286	315	277	277
q15	558	485	492	485
q16	430	496	438	438
q17	1160	1616	1388	1388
q18	7778	7486	7449	7449
q19	822	798	857	798
q20	2016	1972	1845	1845
q21	5155	4797	4639	4639
q22	1124	1060	1047	1047
Total cold run time: 52557 ms
Total hot run time: 50356 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192163 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01f0b7408988b05e06a76ff289821b60bad8d734, data reload: false

query1	1418	1103	1078	1078
query2	6360	1787	1771	1771
query3	11071	4434	4475	4434
query4	55687	24599	23118	23118
query5	5201	486	474	474
query6	388	212	197	197
query7	5068	516	284	284
query8	328	269	250	250
query9	6477	2546	2579	2546
query10	444	326	269	269
query11	15039	15027	14811	14811
query12	164	114	103	103
query13	1142	548	395	395
query14	10223	6413	6375	6375
query15	203	198	188	188
query16	7065	680	509	509
query17	1089	764	600	600
query18	1546	428	335	335
query19	208	230	169	169
query20	131	124	120	120
query21	202	173	106	106
query22	4559	4557	4238	4238
query23	34153	33489	33364	33364
query24	6573	2492	2520	2492
query25	482	494	397	397
query26	669	264	149	149
query27	2194	520	333	333
query28	3216	2106	2070	2070
query29	572	544	447	447
query30	278	229	189	189
query31	837	872	765	765
query32	73	64	65	64
query33	463	381	343	343
query34	821	881	526	526
query35	791	847	760	760
query36	962	984	912	912
query37	111	109	73	73
query38	4213	4342	4225	4225
query39	1496	1421	1460	1421
query40	218	146	102	102
query41	55	60	53	53
query42	129	114	106	106
query43	504	519	479	479
query44	1373	845	820	820
query45	180	176	166	166
query46	856	1045	683	683
query47	1812	1828	1752	1752
query48	383	426	319	319
query49	683	537	429	429
query50	692	720	419	419
query51	4260	4225	4172	4172
query52	106	102	99	99
query53	236	262	192	192
query54	591	599	533	533
query55	83	85	84	84
query56	297	310	300	300
query57	1224	1204	1149	1149
query58	277	277	261	261
query59	2712	2796	2733	2733
query60	334	324	296	296
query61	135	127	127	127
query62	717	736	682	682
query63	239	186	192	186
query64	1545	1058	700	700
query65	4289	4175	4167	4167
query66	712	397	299	299
query67	15796	15535	15185	15185
query68	7752	886	507	507
query69	528	298	262	262
query70	1188	1119	1059	1059
query71	499	327	294	294
query72	5754	4901	4924	4901
query73	1309	701	352	352
query74	9326	8918	8946	8918
query75	3694	3210	2733	2733
query76	4194	1194	763	763
query77	617	365	293	293
query78	10025	10168	9217	9217
query79	2007	816	557	557
query80	659	508	435	435
query81	478	261	216	216
query82	461	122	96	96
query83	423	252	241	241
query84	291	105	91	91
query85	808	364	306	306
query86	429	300	285	285
query87	4372	4346	4268	4268
query88	3691	2238	2226	2226
query89	403	313	278	278
query90	1857	213	210	210
query91	141	138	108	108
query92	71	60	58	58
query93	1706	939	571	571
query94	649	395	291	291
query95	372	293	283	283
query96	487	567	315	315
query97	3184	3270	3150	3150
query98	228	208	193	193
query99	1419	1368	1293	1293
Total cold run time: 301377 ms
Total hot run time: 192163 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.58 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01f0b7408988b05e06a76ff289821b60bad8d734, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.26	0.19	0.19
query4	1.59	0.20	0.10
query5	0.55	0.55	0.56
query6	1.17	0.71	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.58	0.52	0.52
query10	0.58	0.57	0.57
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.62	0.60	0.60
query14	0.78	0.80	0.81
query15	0.86	0.85	0.85
query16	0.37	0.38	0.38
query17	1.04	1.02	1.02
query18	0.21	0.19	0.19
query19	1.88	1.83	1.76
query20	0.01	0.01	0.02
query21	15.42	0.93	0.56
query22	0.76	1.20	1.00
query23	14.71	1.38	0.66
query24	7.06	2.11	0.88
query25	0.52	0.20	0.07
query26	0.67	0.16	0.15
query27	0.05	0.05	0.04
query28	9.51	0.83	0.44
query29	12.54	3.94	3.27
query30	0.25	0.09	0.07
query31	2.82	0.60	0.38
query32	3.23	0.56	0.47
query33	3.09	3.08	3.11
query34	15.75	5.02	4.51
query35	4.51	4.55	4.53
query36	0.68	0.49	0.52
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.09 s
Total hot run time: 29.58 s

@starocean999 starocean999 marked this pull request as ready for review May 14, 2025 06:22
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow added dev/2.1.x dev/3.0.x usercase Important user case type label labels May 16, 2025
@starocean999 starocean999 merged commit e1321a6 into apache:master May 21, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@starocean999
[fix](planner)comparing partition column name should be case insensit…
19f69e5 
…ive when pruning partition in DeleteJob (#50674)
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
github-actions bot pushed a commit that referenced this pull request May 21, 2025
@starocean999
[fix](planner)comparing partition column name should be case insensit…
6a61eb7 
…ive when pruning partition in DeleteJob (#50674)
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 22, 2025
@github-actions @starocean999
branch-3.0: [fix](planner)comparing partition column name should be c…
819d39f 
…ase insensitive when pruning partition in DeleteJob #50674 (#51113)

Cherry-picked from #50674

Co-authored-by: starocean999 <lichi@selectdb.com>
yiguolei pushed a commit that referenced this pull request May 22, 2025
@github-actions @starocean999
branch-2.1: [fix](planner)comparing partition column name should be c…
81b5efa 
…ase insensitive when pruning partition in DeleteJob #50674 (#51114)

Cherry-picked from #50674

Co-authored-by: starocean999 <lichi@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@starocean999 @koarz
[fix](planner)comparing partition column name should be case insensit…
cc25285 
…ive when pruning partition in DeleteJob (apache#50674)
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@924060929 924060929 924060929 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.6-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@starocean999 @hello-stephen @doris-robot @924060929 @morrySnow @yiguolei @dataroaring