Skip to content

[Fix](recycler) Fix transaction label recycling to prevent key cleanup failures and 'key not found' errors #50766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

[Fix](recycler) Fix transaction label recycling to prevent key cleanup failures and 'key not found' errors #50766

merged 1 commit into from
May 12, 2025

Conversation

Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented May 9, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #50037

If an error occurs during transaction label recycling, the vector recording keys cannot be cleaned up. Keys that were already cleaned up in the previous scan and recycle cycle will be carried over to the next scan and recycle cycle, causing a large number of 'key not found' errors.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented May 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.20% (1104/1327)
Line Coverage: 66.19% (18597/28095)
Region Coverage: 65.76% (9255/14074)
Branch Coverage: 55.62% (4984/8960)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4f7eb42cecc3659377b354753c182b97fbee67fc_4f7eb42cecc3659377b354753c182b97fbee67fc_cloud/report/index.html

@gavinchou gavinchou added the p0_b label May 12, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 671a85e into apache:master May 12, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request May 12, 2025
@Yukang-Lian
[Fix](recycler) Fix transaction label recycling to prevent key cleanu…
e194bdd 
…p failures and 'key not found' errors (#50766)

Related PR: #50037 

If an error occurs during transaction label recycling, the vector
recording keys cannot be cleaned up. Keys that were already cleaned up
in the previous scan and recycle cycle will be carried over to the next
scan and recycle cycle, causing a large number of 'key not found'
errors.
@github-actions github-actions bot mentioned this pull request May 12, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 13, 2025
@github-actions @Yukang-Lian
branch-3.0: [Fix](recycler) Fix transaction label recycling to preven…
4bc9ddc 
…t key cleanup failures and 'key not found' errors #50766 (#50814)

Cherry-picked from #50766

Co-authored-by: abmdocrt <Yukang.Lian2022@gmail.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Yukang-Lian @koarz
[Fix](recycler) Fix transaction label recycling to prevent key cleanu…
bfea4dd 
…p failures and 'key not found' errors (apache#50766)

Related PR: apache#50037 

If an error occurs during transaction label recycling, the vector
recording keys cannot be cleaned up. Keys that were already cleaned up
in the previous scan and recycle cycle will be carried over to the next
scan and recycle cycle, causing a large number of 'key not found'
errors.
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

@yagagagaga yagagagaga yagagagaga approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.6-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yukang-Lian @Thearas @doris-robot @gavinchou @yagagagaga @dataroaring