Skip to content

[fix](cooldown) allow cooldown_ttl = 0 when altering storage policy #50830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented May 12, 2025

mysql> ALTER STORAGE POLICY s3_db PROPERTIES ("cooldown_ttl" = "0");
ERROR 1105 (HY000): errCode = 2, detailMessage = cooldown_datetime or cooldown_ttl must be set

@Thearas
Copy link
Contributor

Thearas commented May 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@luwei16
Copy link
Contributor Author

luwei16 commented May 12, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33850 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9a259d412cea6f67a65a5d04333f90a67cd989de, data reload: false

------ Round 1 ----------------------------------
q1	25622	4963	4969	4963
q2	2063	275	185	185
q3	10391	1237	685	685
q4	10234	992	510	510
q5	7537	2323	2306	2306
q6	182	166	135	135
q7	921	714	616	616
q8	9319	1293	1068	1068
q9	6798	5110	5041	5041
q10	6865	2330	1896	1896
q11	497	293	288	288
q12	347	353	212	212
q13	17785	3687	3148	3148
q14	232	229	208	208
q15	526	485	496	485
q16	430	434	369	369
q17	619	844	388	388
q18	7457	7318	7116	7116
q19	1310	923	583	583
q20	337	337	223	223
q21	3944	2673	2497	2497
q22	1032	989	928	928
Total cold run time: 114448 ms
Total hot run time: 33850 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5093	5047	5045	5045
q2	226	319	225	225
q3	2168	2670	2286	2286
q4	1360	1753	1363	1363
q5	4368	4359	4448	4359
q6	213	172	131	131
q7	1985	1957	1811	1811
q8	2552	2580	2506	2506
q9	7199	7171	6878	6878
q10	3085	3204	2759	2759
q11	584	522	490	490
q12	681	774	588	588
q13	3521	3959	3317	3317
q14	289	293	273	273
q15	531	490	485	485
q16	452	492	447	447
q17	1148	1548	1363	1363
q18	7907	7622	7433	7433
q19	815	881	887	881
q20	2047	1998	1827	1827
q21	5198	4812	4757	4757
q22	1095	1041	1013	1013
Total cold run time: 52517 ms
Total hot run time: 50237 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194011 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9a259d412cea6f67a65a5d04333f90a67cd989de, data reload: false

query1	1383	1116	1104	1104
query2	6383	1837	1827	1827
query3	10969	4558	4293	4293
query4	53470	25854	23570	23570
query5	5173	524	474	474
query6	348	217	202	202
query7	4894	530	300	300
query8	341	259	233	233
query9	5421	2655	2657	2655
query10	480	318	266	266
query11	15333	14988	14766	14766
query12	157	108	104	104
query13	1031	513	382	382
query14	10172	6610	6435	6435
query15	201	210	181	181
query16	7102	647	475	475
query17	1077	735	575	575
query18	1548	419	305	305
query19	203	194	179	179
query20	128	129	122	122
query21	203	133	115	115
query22	4439	4451	4300	4300
query23	34162	33540	33504	33504
query24	6596	2447	2408	2408
query25	469	471	412	412
query26	674	273	158	158
query27	2185	516	350	350
query28	3041	2170	2155	2155
query29	576	594	448	448
query30	282	218	192	192
query31	836	853	789	789
query32	70	65	65	65
query33	477	372	357	357
query34	770	865	536	536
query35	793	845	786	786
query36	941	1008	914	914
query37	115	101	76	76
query38	4297	4268	4273	4268
query39	1531	1473	1452	1452
query40	212	119	103	103
query41	59	53	49	49
query42	122	114	115	114
query43	508	495	484	484
query44	1362	863	831	831
query45	183	177	163	163
query46	851	1049	672	672
query47	1898	1917	1780	1780
query48	400	434	315	315
query49	674	515	445	445
query50	678	705	414	414
query51	4349	4225	4235	4225
query52	112	105	101	101
query53	235	274	199	199
query54	595	609	533	533
query55	87	88	88	88
query56	348	310	301	301
query57	1190	1233	1089	1089
query58	270	295	265	265
query59	2723	2812	2731	2731
query60	348	377	307	307
query61	136	134	129	129
query62	736	737	671	671
query63	227	189	201	189
query64	1485	1080	688	688
query65	4466	4322	4242	4242
query66	728	398	307	307
query67	16244	15557	15470	15470
query68	4230	893	540	540
query69	519	325	274	274
query70	1185	1136	1094	1094
query71	434	318	299	299
query72	5920	4825	4931	4825
query73	688	682	353	353
query74	8937	9176	8935	8935
query75	3259	3255	2768	2768
query76	3226	1191	852	852
query77	545	372	307	307
query78	10225	10407	9372	9372
query79	970	890	579	579
query80	715	531	462	462
query81	501	263	221	221
query82	391	127	95	95
query83	264	246	235	235
query84	295	103	90	90
query85	760	350	356	350
query86	360	286	282	282
query87	4450	4513	4376	4376
query88	2885	2297	2303	2297
query89	403	316	285	285
query90	1595	208	216	208
query91	143	144	113	113
query92	63	56	58	56
query93	1551	954	586	586
query94	645	417	272	272
query95	371	302	289	289
query96	502	563	283	283
query97	3111	3232	3189	3189
query98	217	210	208	208
query99	1332	1414	1278	1278
Total cold run time: 290189 ms
Total hot run time: 194011 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9a259d412cea6f67a65a5d04333f90a67cd989de, data reload: false

query1	0.04	0.03	0.04
query2	0.12	0.12	0.11
query3	0.25	0.20	0.19
query4	1.59	0.20	0.11
query5	0.61	0.57	0.55
query6	1.19	0.71	0.73
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.53	0.52
query10	0.56	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.61	0.60	0.59
query14	0.78	0.81	0.82
query15	0.90	0.86	0.85
query16	0.38	0.40	0.38
query17	1.10	1.07	1.03
query18	0.23	0.22	0.21
query19	1.95	1.79	1.85
query20	0.01	0.01	0.02
query21	15.40	0.90	0.55
query22	0.74	1.11	0.69
query23	14.96	1.38	0.62
query24	7.41	1.18	0.47
query25	0.48	0.12	0.08
query26	0.58	0.18	0.14
query27	0.05	0.05	0.04
query28	9.70	0.91	0.44
query29	12.58	4.02	3.31
query30	0.26	0.09	0.07
query31	2.82	0.59	0.39
query32	3.22	0.54	0.47
query33	3.11	3.07	3.08
query34	15.76	5.09	4.50
query35	4.44	4.47	4.44
query36	0.66	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.13	0.12
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.96 s
Total hot run time: 28.81 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@koarz koarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit da1749f into apache:master May 13, 2025
30 checks passed
github-actions bot pushed a commit that referenced this pull request May 13, 2025
…50830)

mysql> ALTER STORAGE POLICY s3_db PROPERTIES ("cooldown_ttl" = "0");
ERROR 1105 (HY000): errCode = 2, detailMessage = cooldown_datetime or cooldown_ttl must be set
@gavinchou gavinchou added usercase Important user case type label dev/2.1.x labels May 13, 2025
github-actions bot pushed a commit that referenced this pull request May 13, 2025
…50830)

mysql> ALTER STORAGE POLICY s3_db PROPERTIES ("cooldown_ttl" = "0");
ERROR 1105 (HY000): errCode = 2, detailMessage = cooldown_datetime or cooldown_ttl must be set
dataroaring pushed a commit that referenced this pull request May 14, 2025
…age policy #50830 (#50854)

Cherry-picked from #50830

Co-authored-by: Luwei <luwei@selectdb.com>
yiguolei pushed a commit that referenced this pull request May 17, 2025
…age policy #50830 (#50856)

Cherry-picked from #50830

Co-authored-by: Luwei <luwei@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…pache#50830)

mysql> ALTER STORAGE POLICY s3_db PROPERTIES ("cooldown_ttl" = "0");
ERROR 1105 (HY000): errCode = 2, detailMessage = cooldown_datetime or cooldown_ttl must be set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.6-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants