Skip to content

[Bug](intersect) fix wrong result of intersect with null literal #50951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 19, 2025
Merged

[Bug](intersect) fix wrong result of intersect with null literal #50951

merged 7 commits into from
May 19, 2025

Conversation

BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented May 15, 2025 •
edited
Loading

What problem does this PR solve?

fix wrong result of intersect with null literal

图片

InferPredicates will generate equal predicate on intersect/except operator's child, intersect/except operator require null safe equal to make 'null intersect null' return null instead of empty set
图片

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor

please add more detail in desc about how infer predicate influence set operation with null literal?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

yujun777
yujun777 approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 19, 2025
@BiteTheDDDDt BiteTheDDDDt merged commit 5aa3832 into apache:master May 19, 2025
26 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request May 23, 2025
@BiteTheDDDDt
[Bug](intersect) fix wrong result of intersect with null literal (#50951
29cf54e 
)

### What problem does this PR solve?
 fix wrong result of intersect with null literal


![图片](https://github.com/user-attachments/assets/fc54b110-4d3d-43fc-a36a-014379b1d485)

InferPredicates will generate equal predicate on intersect/except
operator's child, intersect/except operator require null safe equal to
make 'null intersect null' return null instead of empty set

![图片](https://github.com/user-attachments/assets/78be5ed1-65a0-4f0e-b138-0ef7b6a461d0)
@github-actions github-actions bot mentioned this pull request May 23, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 23, 2025
@github-actions @BiteTheDDDDt
branch-3.0: [Bug](intersect) fix wrong result of intersect with null …
2576d6b 
…literal #50951 (#51178)

Cherry-picked from #50951

Co-authored-by: Pxl <xl@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt @koarz
[Bug](intersect) fix wrong result of intersect with null literal (apa…
3cfe90e 
…che#50951)

### What problem does this PR solve?
 fix wrong result of intersect with null literal


![图片](https://github.com/user-attachments/assets/fc54b110-4d3d-43fc-a36a-014379b1d485)

InferPredicates will generate equal predicate on intersect/except
operator's child, intersect/except operator require null safe equal to
make 'null intersect null' return null instead of empty set

![图片](https://github.com/user-attachments/assets/78be5ed1-65a0-4f0e-b138-0ef7b6a461d0)
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujun777 yujun777 yujun777 approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.6-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BiteTheDDDDt @hello-stephen @morrySnow @yujun777 @feiniaofeiafei @dataroaring