[Fix](cloud-mow) Full compaction should only update delete bitmap of its output rowset #50974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33874 ms |
TPC-DS: Total hot run time: 192929 ms |
ClickBench: Total hot run time: 29.27 s |
|
run p0 |
zhannngchen
reviewed
May 16, 2025
| @@ -377,7 +377,8 @@ Status CloudFullCompaction::_cloud_full_compaction_calc_delete_bitmap( | |||
| segments.begin(), segments.end(), 0, | |||
| [](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); }); | |||
| for (const auto& [k, v] : tmp_delete_bitmap->delete_bitmap) { | |||
| if (std::get<1>(k) != DeleteBitmap::INVALID_SEGMENT_ID) { | |||
| if (std::get<0>(k) == _output_rowset->rowset_id() && | |||
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
May 16, 2025
…its output rowset (#50974) ### What problem does this PR solve? When table has sequence column, full compaction may generate delete bitmap marks on published rowset when calculating delete bitmaps for incremental rowsets. This will cause correctness problem when those published rowset has multi segments and have duplicate keys between those segments because full compaction will **override** the origin delete bitmaps on those segment currently. To fix it, full compaction should only update delete bitmaps of its own output rowset.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…its output rowset (apache#50974) ### What problem does this PR solve? When table has sequence column, full compaction may generate delete bitmap marks on published rowset when calculating delete bitmaps for incremental rowsets. This will cause correctness problem when those published rowset has multi segments and have duplicate keys between those segments because full compaction will **override** the origin delete bitmaps on those segment currently. To fix it, full compaction should only update delete bitmaps of its own output rowset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When table has sequence column, full compaction may generate delete bitmap marks on published rowset when calculating delete bitmaps for incremental rowsets. This will cause correctness problem when those published rowset has multi segments and have duplicate keys between those segments because full compaction will override the origin delete bitmaps on those segment currently.
To fix it, full compaction should only update delete bitmaps of its own output rowset.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)