Skip to content

[fix](metadata) replace view will break view's metadata #51058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

[fix](metadata) replace view will break view's metadata #51058

merged 1 commit into from
May 20, 2025
+39 −0

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Related PR: #40715

Problem Summary:

this problem intro by #40715, when do replace view, full schema do not be set correctly. So view's schema will lost after replace.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@morrySnow
[fix](metadata) replace view will break view's metadata
c96eda5 
this problem intro by apache#40715, when do replace view, full schema do not
be set correctly. So view's schema will lost after replace.
@Thearas
Copy link
Contributor

Thearas commented May 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33687 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c96eda51c349c8c5d7526348b6f1497576d22e92, data reload: false

------ Round 1 ----------------------------------
q1	26447	5029	4991	4991
q2	2094	287	176	176
q3	10404	1235	708	708
q4	10236	1012	527	527
q5	7495	2409	2312	2312
q6	179	163	130	130
q7	908	730	614	614
q8	9316	1280	1091	1091
q9	6749	5062	5005	5005
q10	6820	2310	1884	1884
q11	478	283	285	283
q12	357	359	217	217
q13	17789	3614	3096	3096
q14	243	228	219	219
q15	546	491	502	491
q16	441	428	378	378
q17	574	874	360	360
q18	7914	7144	7180	7144
q19	1237	961	556	556
q20	330	330	232	232
q21	3724	2530	2300	2300
q22	1047	1008	973	973
Total cold run time: 115328 ms
Total hot run time: 33687 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5087	5069	5081	5069
q2	239	325	225	225
q3	2178	2653	2268	2268
q4	1354	1810	1398	1398
q5	4448	4489	4441	4441
q6	222	172	137	137
q7	2059	1917	1757	1757
q8	2593	2460	2616	2460
q9	7048	7221	7217	7217
q10	3026	3152	2741	2741
q11	577	515	502	502
q12	685	788	612	612
q13	3523	3959	3232	3232
q14	271	303	260	260
q15	542	500	500	500
q16	458	489	430	430
q17	1118	1522	1392	1392
q18	7768	7566	7430	7430
q19	815	748	844	748
q20	1974	1986	1890	1890
q21	4871	4357	4340	4340
q22	1041	1032	999	999
Total cold run time: 51897 ms
Total hot run time: 50048 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185502 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c96eda51c349c8c5d7526348b6f1497576d22e92, data reload: false

query1	1009	472	511	472
query2	6577	1824	1808	1808
query3	6767	219	225	219
query4	26700	23701	22967	22967
query5	4352	622	448	448
query6	296	200	194	194
query7	4618	492	294	294
query8	288	232	227	227
query9	8611	2627	2654	2627
query10	472	337	282	282
query11	15416	15022	14890	14890
query12	154	106	98	98
query13	1639	505	402	402
query14	8647	6082	6089	6082
query15	205	191	173	173
query16	7136	630	464	464
query17	950	735	593	593
query18	1979	402	301	301
query19	195	195	179	179
query20	121	113	122	113
query21	221	125	110	110
query22	4203	4122	4112	4112
query23	34015	33007	33127	33007
query24	8414	2417	2400	2400
query25	560	500	416	416
query26	1237	270	157	157
query27	2754	510	341	341
query28	4313	2127	2096	2096
query29	785	625	427	427
query30	288	216	185	185
query31	931	849	763	763
query32	85	62	62	62
query33	564	364	312	312
query34	784	832	535	535
query35	786	794	731	731
query36	954	998	860	860
query37	116	102	75	75
query38	4162	4068	4011	4011
query39	1550	1410	1406	1406
query40	212	121	104	104
query41	57	58	65	58
query42	137	114	107	107
query43	499	518	490	490
query44	1309	831	820	820
query45	176	177	169	169
query46	832	1019	633	633
query47	1755	1809	1720	1720
query48	386	423	317	317
query49	771	508	424	424
query50	653	673	413	413
query51	4108	4195	4044	4044
query52	119	109	98	98
query53	221	250	190	190
query54	594	575	502	502
query55	83	87	83	83
query56	328	293	277	277
query57	1118	1155	1076	1076
query58	262	255	253	253
query59	2537	2625	2625	2625
query60	320	324	319	319
query61	129	118	121	118
query62	795	736	658	658
query63	236	190	191	190
query64	4365	991	653	653
query65	4284	4169	4265	4169
query66	1152	408	321	321
query67	15971	15505	15456	15456
query68	8489	876	528	528
query69	488	316	266	266
query70	1173	1121	1072	1072
query71	478	327	313	313
query72	5405	4713	4831	4713
query73	722	628	355	355
query74	8873	8883	8867	8867
query75	4064	3177	2667	2667
query76	3725	1179	741	741
query77	785	392	293	293
query78	10034	10239	9355	9355
query79	2015	819	569	569
query80	624	548	442	442
query81	469	259	230	230
query82	464	126	94	94
query83	289	263	234	234
query84	295	111	82	82
query85	814	366	313	313
query86	343	330	279	279
query87	4366	4378	4413	4378
query88	2953	2336	2324	2324
query89	399	319	281	281
query90	1950	208	204	204
query91	139	137	114	114
query92	77	59	59	59
query93	1390	927	586	586
query94	674	395	320	320
query95	370	289	276	276
query96	494	583	282	282
query97	2730	2722	2679	2679
query98	227	208	220	208
query99	1416	1369	1252	1252
Total cold run time: 272997 ms
Total hot run time: 185502 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.99 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c96eda51c349c8c5d7526348b6f1497576d22e92, data reload: false

query1	0.04	0.04	0.04
query2	0.12	0.11	0.10
query3	0.26	0.20	0.19
query4	1.59	0.19	0.19
query5	0.45	0.45	0.44
query6	1.51	0.66	0.68
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.54	0.53
query10	0.59	0.59	0.59
query11	0.15	0.12	0.12
query12	0.14	0.12	0.12
query13	0.61	0.60	0.60
query14	0.80	0.80	0.80
query15	0.86	0.85	0.86
query16	0.38	0.39	0.38
query17	1.00	1.04	1.04
query18	0.22	0.21	0.20
query19	1.89	1.80	1.82
query20	0.01	0.01	0.01
query21	15.40	0.88	0.53
query22	0.76	1.16	0.68
query23	14.95	1.34	0.61
query24	6.73	2.21	0.77
query25	0.51	0.24	0.06
query26	0.61	0.16	0.14
query27	0.06	0.05	0.05
query28	9.34	0.82	0.44
query29	12.54	3.97	3.33
query30	0.25	0.09	0.06
query31	3.12	0.60	0.38
query32	3.23	0.53	0.47
query33	3.11	3.04	3.16
query34	15.60	5.05	4.48
query35	4.50	4.49	4.47
query36	0.67	0.50	0.47
query37	0.08	0.06	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.09	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.17 s
Total hot run time: 28.99 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit b0612ed into apache:master May 20, 2025
28 of 30 checks passed
@morrySnow morrySnow deleted the fix_replace_view branch May 20, 2025 07:31
github-actions bot pushed a commit that referenced this pull request May 20, 2025
@morrySnow
[fix](metadata) replace view will break view's metadata (#51058)
806b00d 
### What problem does this PR solve?

Related PR: #40715

Problem Summary:

this problem intro by #40715, when do replace view, full schema do not
be set correctly. So view's schema will lost after replace.
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 21, 2025
@github-actions @morrySnow
branch-3.0: [fix](metadata) replace view will break view's metadata #…
53e33c8 
…51058 (#51074)

Cherry-picked from #51058

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morrySnow @koarz
[fix](metadata) replace view will break view's metadata (apache#51058)
c6e65ac 
### What problem does this PR solve?

Related PR: apache#40715

Problem Summary:

this problem intro by apache#40715, when do replace view, full schema do not
be set correctly. So view's schema will lost after replace.
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.6-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @Thearas @doris-robot @morningman @feiniaofeiafei @dataroaring