Skip to content

[enhancement](cloud-schema-change) Enable new tablet to do compactionby default #51070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

TangSiyang2001
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 commented May 20, 2025

What problem does this PR solve?

As title.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented May 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 34038 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 36ce70166c5a16ba4afde91382dbfec305e5dd2e, data reload: false

------ Round 1 ----------------------------------
q1	25986	5068	4991	4991
q2	2078	285	197	197
q3	10561	1248	699	699
q4	10237	1005	541	541
q5	7801	2458	2320	2320
q6	190	164	138	138
q7	919	740	616	616
q8	9323	1340	1110	1110
q9	6811	5103	5080	5080
q10	6802	2320	1904	1904
q11	500	276	272	272
q12	349	353	212	212
q13	17759	3699	3141	3141
q14	242	235	216	216
q15	535	491	490	490
q16	439	447	386	386
q17	603	876	370	370
q18	7745	7242	7206	7206
q19	1666	953	574	574
q20	330	345	222	222
q21	3825	3177	2382	2382
q22	1063	1015	971	971
Total cold run time: 115764 ms
Total hot run time: 34038 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5168	5092	5126	5092
q2	248	330	237	237
q3	2195	2685	2304	2304
q4	1298	1785	1390	1390
q5	4577	4414	4341	4341
q6	213	170	130	130
q7	2006	1881	1737	1737
q8	2648	2575	2545	2545
q9	7070	7139	7113	7113
q10	2994	3173	2738	2738
q11	572	505	486	486
q12	671	784	612	612
q13	4058	3897	3242	3242
q14	277	299	278	278
q15	524	479	479	479
q16	438	501	441	441
q17	1155	1563	1382	1382
q18	7645	7475	7397	7397
q19	829	811	1002	811
q20	2026	2012	1871	1871
q21	4785	4392	4313	4313
q22	1063	1047	979	979
Total cold run time: 52460 ms
Total hot run time: 49918 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185638 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 36ce70166c5a16ba4afde91382dbfec305e5dd2e, data reload: false

query1	1019	497	494	494
query2	6551	1878	1883	1878
query3	6753	220	223	220
query4	26181	23694	23375	23375
query5	4317	604	473	473
query6	289	202	200	200
query7	4621	479	281	281
query8	280	269	238	238
query9	8599	2617	2622	2617
query10	491	344	276	276
query11	15702	15089	14841	14841
query12	159	111	112	111
query13	1661	559	412	412
query14	8990	6211	5969	5969
query15	199	185	166	166
query16	7151	628	456	456
query17	1189	688	560	560
query18	2007	381	300	300
query19	188	187	157	157
query20	115	114	122	114
query21	217	160	106	106
query22	4017	4134	4060	4060
query23	33952	33009	32861	32861
query24	8454	2397	2384	2384
query25	535	453	395	395
query26	1233	260	152	152
query27	2767	500	330	330
query28	4332	2111	2082	2082
query29	766	578	449	449
query30	283	217	188	188
query31	934	841	773	773
query32	73	67	64	64
query33	566	383	323	323
query34	814	861	517	517
query35	792	822	732	732
query36	970	979	859	859
query37	109	101	79	79
query38	4103	4075	4016	4016
query39	1504	1575	1385	1385
query40	213	125	103	103
query41	59	53	53	53
query42	123	139	106	106
query43	500	527	484	484
query44	1305	823	827	823
query45	182	177	172	172
query46	844	1023	646	646
query47	1762	1790	1770	1770
query48	382	416	304	304
query49	792	509	427	427
query50	646	677	416	416
query51	4206	4080	4121	4080
query52	110	109	106	106
query53	222	255	186	186
query54	588	577	500	500
query55	87	88	81	81
query56	312	314	297	297
query57	1108	1141	1082	1082
query58	276	263	248	248
query59	2760	2995	2723	2723
query60	327	317	321	317
query61	159	150	146	146
query62	796	750	671	671
query63	228	189	189	189
query64	4460	1089	754	754
query65	4309	4220	4298	4220
query66	1164	431	379	379
query67	16028	15733	15555	15555
query68	8567	880	523	523
query69	473	310	269	269
query70	1215	1095	1093	1093
query71	460	334	297	297
query72	5422	4625	4695	4625
query73	696	578	357	357
query74	9143	9117	8661	8661
query75	3962	3180	2684	2684
query76	3653	1192	748	748
query77	778	367	298	298
query78	10138	10513	9272	9272
query79	1895	815	573	573
query80	596	516	454	454
query81	459	259	218	218
query82	424	128	98	98
query83	262	250	237	237
query84	246	105	91	91
query85	781	357	311	311
query86	337	287	308	287
query87	4470	4422	4263	4263
query88	3173	2323	2366	2323
query89	390	312	277	277
query90	1931	207	204	204
query91	142	146	109	109
query92	77	59	57	57
query93	1110	933	586	586
query94	671	410	294	294
query95	374	293	278	278
query96	506	567	282	282
query97	2661	2773	2646	2646
query98	245	207	205	205
query99	1384	1426	1287	1287
Total cold run time: 273472 ms
Total hot run time: 185638 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 36ce70166c5a16ba4afde91382dbfec305e5dd2e, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.12
query3	0.26	0.19	0.19
query4	1.60	0.19	0.11
query5	0.43	0.43	0.43
query6	1.18	0.65	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.61	0.53	0.52
query10	0.57	0.59	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.60	0.59
query14	0.78	0.80	0.82
query15	0.88	0.87	0.85
query16	0.40	0.40	0.39
query17	1.03	1.05	1.01
query18	0.22	0.21	0.21
query19	1.99	1.84	1.78
query20	0.02	0.00	0.01
query21	15.41	0.92	0.53
query22	0.76	1.25	0.67
query23	14.86	1.40	0.64
query24	7.47	1.76	0.35
query25	0.28	0.14	0.13
query26	0.61	0.16	0.14
query27	0.05	0.05	0.05
query28	9.24	0.92	0.45
query29	12.58	4.01	3.36
query30	0.26	0.09	0.06
query31	2.81	0.59	0.38
query32	3.25	0.55	0.47
query33	3.12	3.03	3.08
query34	15.71	5.04	4.52
query35	4.50	4.49	4.49
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 103.18 s
Total hot run time: 28.55 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.95% (14924/26675)
Line Coverage 44.76% (132398/295770)
Region Coverage 43.86% (66613/151882)
Branch Coverage 38.45% (34136/88778)

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 23, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit f4d78f5 into apache:master May 23, 2025
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request May 23, 2025
dataroaring pushed a commit that referenced this pull request May 23, 2025
…o compactionby default #51070 (#51186)

Cherry-picked from #51070

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants