-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Fix](Compaction) Fix delete rowset sleeping when compaction #51482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
run buildall |
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run beut |
28890bb
to
a30fe4f
Compare
run buildall |
TPC-H: Total hot run time: 33734 ms
|
TPC-DS: Total hot run time: 193115 ms
|
ClickBench: Total hot run time: 29.15 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
In #50950, we enhanced the observability of compaction, but in some places, the last_cumu_compaction_failure_time was incorrectly set, causing it to be set when encountering a delete rowset. As a result, when compaction encountered a delete rowset, it would consider it a failure and sleep for 5 seconds. This PR fixes the issue.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)