Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.protobuf:protobuf-java from 3.16.3 to 3.25.5 #2945

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 27, 2024

Bumps com.google.protobuf:protobuf-java from 3.16.3 to 3.25.5.

Release notes

Sourced from com.google.protobuf:protobuf-java's releases.

Protocol Buffers v3.20.3

Java

  • Refactoring java full runtime to reuse sub-message builders and prepare to migrate parsing logic from parse constructor to builder.
  • Move proto wireformat parsing functionality from the private "parsing constructor" to the Builder class.
  • Change the Lite runtime to prefer merging from the wireformat into mutable messages rather than building up a new immutable object before merging. This way results in fewer allocations and copy operations.
  • Make message-type extensions merge from wire-format instead of building up instances and merging afterwards. This has much better performance.
  • Fix TextFormat parser to build up recurring (but supposedly not repeated) sub-messages directly from text rather than building a new sub-message and merging the fully formed message into the existing field.
  • This release addresses a Security Advisory for Java users

Protocol Buffers v3.20.2

C++

Protocol Buffers v3.20.1

PHP

  • Fix building packaged PHP extension (#9727)
  • Fixed composer.json to only advertise compatibility with PHP 7.0+. (#9819)

Ruby

  • Disable the aarch64 build on macOS until it can be fixed. (#9816)

Other

  • Fix versioning issues in 3.20.0

Protocol Buffers v3.20.1-rc1

PHP

  • Fix building packaged PHP extension (#9727)

Other

  • Fix versioning issues in 3.20.0

Protocol Buffers v3.20.0

2022-03-25 version 3.20.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript)

Ruby

  • Dropped Ruby 2.3 and 2.4 support for CI and releases. (#9311)
  • Added Ruby 3.1 support for CI and releases (#9566).
  • Message.decode/encode: Add recursion_limit option (#9218/#9486)
  • Allocate with xrealloc()/xfree() so message allocation is visible to the Ruby GC. In certain tests this leads to much lower memory usage due to more frequent GC runs (#9586).
  • Fix conversion of singleton classes in Ruby (#9342)

... (truncated)

Commits
  • 9d0ec0f Updating version.json and repo version numbers to: 25.5
  • 4a197e7 Merge pull request #18387 from protocolbuffers/cp-lp-25
  • b5a7cf7 Remove RecursiveGroup test case which doesn't exist in 25.x pre-Editions
  • f000b7e Fix merge conflict by adding optional label to proto2 unittest_lite.proto
  • 4728531 Add recursion check when parsing unknown fields in Java.
  • 850fcce Internal change
  • b704498 Internal change
  • e673479 Fix cord handling in DynamicMessage and oneofs. (#18375)
  • 8a60b65 Merge pull request #17704 from protocolbuffers/cp-segv
  • 94a2663 Fixed a SEGV when deep copying a non-reified sub-message.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@pjfanning
Copy link
Contributor

Test failures caused by:

org.testcontainers.containers.ContainerLaunchException: Container startup failed for image mcr.microsoft.com/mssql/server:2017-CU12
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349)
	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322)
	at org.apache.drill.exec.store.jdbc.TestJdbcPluginWithMSSQL.initMSSQL(TestJdbcPluginWithMSSQL.java:68)
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
	at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
	... 2 more

@cgivre
Copy link
Contributor

cgivre commented Oct 9, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 9, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@pjfanning
Copy link
Contributor

@cgivre Dependabot says no to rebase, I can rebase and force push.

Bumps [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.16.3 to 3.25.5.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](protocolbuffers/protobuf@v3.16.3...v3.25.5)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-java
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@pjfanning pjfanning force-pushed the dependabot/maven/com.google.protobuf-protobuf-java-3.25.5 branch from 2ba8a81 to 9da0095 Compare October 9, 2024 18:02
@pjfanning
Copy link
Contributor

Looks like we need more changes.

Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0/plexus-utils-3.0.jar (226 kB at 1.9 MB/s)
[INFO] Protobuf dependency version 3.25.5
[INFO] 'protoc' executable version 3.16.3
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12.972 s
[INFO] Finished at: 2024-10-09T18:21:13Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal com.github.igor-petruk.protobuf:protobuf-maven-plugin:0.6.5:run (default) on project drill-protocol: Protobuf installation version does not match Protobuf library version -> [Help 1]

Update pom.xml

try arduino/setup-protoc

Update pom.xml

Update ci.yml

Update ci.yml

revert ci.yml

Update ci.yml
@pjfanning pjfanning force-pushed the dependabot/maven/com.google.protobuf-protobuf-java-3.25.5 branch from 72e8b36 to 6026d70 Compare October 10, 2024 09:12
@@ -120,6 +120,7 @@
<configuration>
<cleanOutputFolder>false</cleanOutputFolder>
<outputDirectory>${basedir}/src/main/java</outputDirectory>
<ignoreVersions>true</ignoreVersions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needed because there is a CI job that uses an older protobuf lib than our protobuf-java lib
  • I tried to get the CI job to use a newer protobuf lib but the format of the protobuf zip has changed and I'm not sure how to get the existing build to use a newer protobuf zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants