refine grpc test code #1266
Merged
refine grpc test code #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2021 17:10
Codecov Report
@@ Coverage Diff @@
## 3.0 #1266 +/- ##
==========================================
- Coverage 59.53% 55.74% -3.79%
==========================================
Files 259 272 +13
Lines 12737 12809 +72
==========================================
- Hits 7583 7141 -442
- Misses 4199 4765 +566
+ Partials 955 903 -52
Continue to review full report at Codecov.
|
zouyx
approved these changes
Jun 21, 2021
AlexStocks
approved these changes
Jun 21, 2021
zouyx
reviewed
Jun 22, 2021
LaurenceLiZhixin
approved these changes
Jun 25, 2021
mark4z
pushed a commit
to mark4z/dubbo-go
that referenced
this pull request
Jul 5, 2021
* refine grpc test code * fix test * remove useless code * config test grpc server
AlexStocks
added a commit
that referenced
this pull request
Jul 5, 2021
…1300) * build(deps): bump actions/cache from v2.1.4 to v2.1.5 Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.4...1a9e213) Signed-off-by: dependabot[bot] <support@github.com> * improve etcd version and change create to put (#1203) * make the package v3router/judger test coverage rate reach 80% (#1260) * make the package v3router/judger test coverage rate reach 80% * add router_chain unit test * refactor imports and some code * remove blank lines Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com> * Fix: Graceful shutdown bugs(supplement #1254) (#1257) * supplementary fix #1254 remove unused comments fix import cycle append apache license header fix gracefulShutdownFilter unittest bug go fmt fix gracefulShutdownConfig unittest bug fix gracefulShutdownConfig unittest bug go fmt * improve formatting based on code style * go fmt * set RequestsFinished explicitly * use mutex to protect variables of ShutdownConfig * ftr: add config (#1258) * recover gracefulShutdownFilter logic * remove unused mutex Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com> * refine grpc test code (#1266) * refine grpc test code * fix test * remove useless code * config test grpc server * registry 默认值问题 (#1275) Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn> * config center for more parameters (#1277) * nacos config center optimize * up remote config * add protocol chick * up:代码优化 * go fmt * fix: add arch picture in readme and delete unused router field. (#1279) * fix * fix: delete notify * performance optimization: change time.After => time.NewTimer Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com> Co-authored-by: AlexStocks <alexstocks@foxmail.com> Co-authored-by: randy <ztelur@gmail.com> Co-authored-by: LaurenceLiZhixin <382673304@qq.com> Co-authored-by: Mulavar <978007503@qq.com> Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com> Co-authored-by: XavierNiu <a@nxw.name> Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com> Co-authored-by: gaoxinge <xg.gao@tianrang-inc.com> Co-authored-by: wangxw666 <2484713618@qq.com> Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn> Co-authored-by: 赵云兴 <2385585770@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
protocol/grpc/common_test.go, because there is no test function in it, and we can reuse the code inprotocol/internal/server.goSpecial notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: