-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance optimization: change time.After => time.NewTimer for 3.0 #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.4...1a9e213) Signed-off-by: dependabot[bot] <support@github.com>
…develop/actions/cache-v2.1.5 build(deps): bump actions/cache from v2.1.4 to v2.1.5
…#1260) * make the package v3router/judger test coverage rate reach 80% * add router_chain unit test * refactor imports and some code * remove blank lines Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com>
* supplementary fix apache#1254 remove unused comments fix import cycle append apache license header fix gracefulShutdownFilter unittest bug go fmt fix gracefulShutdownConfig unittest bug fix gracefulShutdownConfig unittest bug go fmt * improve formatting based on code style * go fmt * set RequestsFinished explicitly * use mutex to protect variables of ShutdownConfig * ftr: add config (apache#1258) * recover gracefulShutdownFilter logic * remove unused mutex Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>
* refine grpc test code * fix test * remove useless code * config test grpc server
Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn>
* nacos config center optimize * up remote config * add protocol chick * up:代码优化 * go fmt
…he#1279) * fix * fix: delete notify
Codecov Report
@@ Coverage Diff @@
## 3.0 #1300 +/- ##
==========================================
+ Coverage 55.58% 56.18% +0.60%
==========================================
Files 272 273 +1
Lines 12809 12780 -29
==========================================
+ Hits 7120 7181 +61
+ Misses 4783 4694 -89
+ Partials 906 905 -1
Continue to review full report at Codecov.
|
justxuewei
approved these changes
Jul 5, 2021
AlexStocks
approved these changes
Jul 5, 2021
cvictory
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
performance optimization: change time.After => time.NewTimer
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: