Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Springframework 6 removed class InstantiationAwareBeanPostProcessorAdapter (#10953) #10954

Closed
wants to merge 2 commits into from

Conversation

gitchenjh
Copy link
Contributor

@gitchenjh gitchenjh commented Nov 18, 2022

What is the purpose of the change

Fix #10953 & #10966

Brief changelog

Remove class org.springframework.beans.factory.config.InstantiationAwareBeanPostProcessorAdapter because it's removed in Spring Framework 6
Add AutoConfiguration.imports for Spring Boot 2.7 and later support

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (9bbca3a) to head (e99e118).
Report is 236 commits behind head on 3.1.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.1   #10954      +/-   ##
============================================
- Coverage     68.92%   64.75%   -4.18%     
+ Complexity      100       14      -86     
============================================
  Files          1461     1419      -42     
  Lines         75675    58883   -16792     
  Branches      13255     8646    -4609     
============================================
- Hits          52161    38129   -14032     
+ Misses        18899    16734    -2165     
+ Partials       4615     4020     -595     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weixsun
Copy link
Contributor

weixsun commented Nov 19, 2022

@gitchenjh This is a duplicate of #10697, and it has been merged into the 3.2 branch.

Additionally, work to support Spring 6 and Spring Boot 3 will be done in #10941, which will then also be merged into the 3.2 branch.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated with #10697.
BTW, the 3.1 branch should not merge in any feature due to stability considerations.

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@gitchenjh
Copy link
Contributor Author

duplicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dubbo 3.1.x are not compatible with Spring Framework 6
5 participants