Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client flowcontrol #11029

Merged
merged 2 commits into from
Nov 28, 2022
Merged

client flowcontrol #11029

merged 2 commits into from
Nov 28, 2022

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Nov 25, 2022

What is the purpose of the change

Triple client flowcontrol
TriHttp2RemoteFlowController isOverFlowControl
when windowsize=0,will throw flowexception.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

client flowcontrol
Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bugfix
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

56.1% 56.1% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11029 (916ba60) into 3.2 (10082d3) will increase coverage by 0.01%.
The diff coverage is 54.51%.

@@             Coverage Diff              @@
##                3.2   #11029      +/-   ##
============================================
+ Coverage     64.83%   64.85%   +0.01%     
  Complexity       14       14              
============================================
  Files          1443     1445       +2     
  Lines         59916    60236     +320     
  Branches       8778     8827      +49     
============================================
+ Hits          38846    39064     +218     
- Misses        16958    17070     +112     
+ Partials       4112     4102      -10     
Impacted Files Coverage Δ
.../dubbo/rpc/protocol/tri/call/TripleClientCall.java 29.45% <0.00%> (-2.40%) ⬇️
...rpc/protocol/tri/TriHttp2RemoteFlowController.java 56.32% <56.32%> (ø)
...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java 88.57% <100.00%> (+0.69%) ⬆️
...gistrycenter/processor/ZookeeperUnixProcessor.java 60.71% <0.00%> (-17.86%) ⬇️
...apache/dubbo/remoting/transport/DecodeHandler.java 85.71% <0.00%> (-9.53%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 84.84% <0.00%> (-6.07%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-4.35%) ⬇️
...egistry/kubernetes/KubernetesServiceDiscovery.java 75.94% <0.00%> (-4.25%) ⬇️
.../dubbo/common/logger/log4j/Log4jLoggerAdapter.java 87.87% <0.00%> (-3.96%) ⬇️
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 55.26% <0.00%> (-3.95%) ⬇️
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants