Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceConfig Ref unable to toString #12511

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 12, 2023

What is the purpose of the change

Brief changelog

    @Test
    void testToString() {
        ServiceConfig<DemoService> serviceConfig = new ServiceConfig<>();
        service.setRef(new DemoServiceImpl() {
            @Override
            public String toString() {
                throw new IllegalStateException();
            }
        });
        try {
            serviceConfig.toString();
        } catch (Throwable t) {
            Assertions.fail(t);
        }
    }

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

46.6% 46.6% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 83b4114 into apache:3.2 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant