Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable accesslog while the config of dubbo.protocol.accesslog is false #14257

Merged
merged 1 commit into from
May 31, 2024

Conversation

aofall
Copy link
Contributor

@aofall aofall commented May 30, 2024

What is the purpose of the change

In the official document the option of dubbo.protocol.accesslog can be set as string/boolean type. While it's true value, it will active accesslog and write to the default path currently, but while it's false value, it will still active and write accesslog and output the warning.

image

Brief changelog

disable accesslog while the config of dubbo.protocol.accesslog is false

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented May 30, 2024

@AlbumenJ AlbumenJ merged commit d35d7eb into apache:3.2 May 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants